Repository navigation
Fall back to any-args when an expr does not reach the closing paren - #13
Merged
Merged
Conversation
In `[ <expr>? || <any-args> ]` the first branch always succeeds, so any- args is only reached by backtracking into the alternation once the ')' fails. That only works because an alternation followed by whitespace in a rule is currently not ratcheted, which rakudo may change in the future. Requiring the ')' after the expr keeps the fallback reachable either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
[ <expr>? || <any-args> ]the first branch always succeeds, so any- args is only reached by backtracking into the alternation once the ')' fails. That only works because an alternation followed by whitespace in a rule is currently not ratcheted, which rakudo may change in the future. Requiring the ')' after the expr keeps the fallback reachable either way.