Add DL3 writer#2979
Conversation
|
kosack
left a comment
kosack
left a comment
There was a problem hiding this comment.
I'm still working through this, so this is not yet a complete review, but here are a few initial comments
|
|
||
| @pytest.fixture(scope="session") | ||
| def dl2_events_for_dl3(single_obs_gamma_diffuse_full_reco_file, dl2_meta_for_dl3): | ||
| preprocessor = DL2EventPreprocessor( |
There was a problem hiding this comment.
If you like, I can open a PR to this branch to convert this to use the new EventPreprocessor, which could simplify a lot of the code.
There was a problem hiding this comment.
See #3004 where I started to see what changes I need to EventPreprocessor to support the DL2 to DL3 transition
There was a problem hiding this comment.
Please feel free to do it.
| __all__ = ["DL3EventsWriter", "DL3GADFEventsWriter"] | ||
|
|
||
|
|
||
| class DL3EventsWriter(Component): |
There was a problem hiding this comment.
My main comment here is that I think that the DL3 writer should not store state of the observation.
The inputs to the actual writing function should be the event list, the irfs and additionally needed data, but it should not keep that as state on the writer instance.
It should be possible to write multiple observation blocks using the same instance of the writer.
There was a problem hiding this comment.
I've added the a data class as suggested and it should address your comments. Let me know.
|
@mdebony please rebase against the main branch to get the fixes for the CI |
3 participants
Add a DL3 writer for the GADF format to catapipe.
This PR is sub element of #2727 to simplify the review.