Repository navigation
Feat/add custom command - #10
Conversation
301340f to
3f87337
Compare
3f87337 to
5a63844
Compare
5a63844 to
8e329be
Compare
8e329be to
eaac970
Compare
eaac970 to
4ae6dc5
Compare
8590df5 to
e95b948
Compare
| # Independent if the step was executed or not, every step shall update the context | ||
| step.update_execution_context() | ||
|
|
||
| if self.command: |
There was a problem hiding this comment.
Why do we need to wrap the custom command as a pipeline step and not just use the execution context subprocess executor?
You have to consider the fact that the pypeline run shall exit even if the process that was started did not. If I for example use the pypeline run with the "code ." command, I would like that the pypeline execution exits but the VS Code still runs. How is this handled?
e95b948 to
6f44921
Compare
6f44921 to
8230f79
Compare
|
Hi @code-steadfast, thanks for taking care of this issue. I think we need to cover to separate use cases:
I think we need an extra argument for this with the default to wait for the process to finish. What do you think? Did you test this feature locally? |
|
Hi @cuinixam, Thanks to you for reviewing and I tested locally and its working
Regarding extra argument may be I try something like "Popen" option |
f831ebb to
e6e2294
Compare
|
Hi @cuinixam, Please check these changes. Thanks 😸 |
|
I think it is better if we explicitly separate the commands which shall run at the end of the pipeline and an application that shall be started after the pipeline runs. For example:
We can discuss if the name |
e6e2294 to
2ce46e8
Compare
|
Fixes #3 |
#3