Repository navigation
feat: steps prepend their install directories to the PATH - #17
Open
code-steadfast wants to merge 1 commit into
Open
code-steadfast wants to merge 1 commit into
code-steadfast wants to merge 1 commit into
Conversation
Owner
|
I do not think this is flexible enough to cover different use cases from the users. With such a change we only solve the current problem we have with the venv paths to be found before the user python paths. I would suggest we take a more generic approach:
The paths registered with the same order shall keep the order of when they were registered. For example, three paths A,B,C registered with order 13 will be put in the list based on the order number but keep the ordering A, B, C.
We can also consider to have the include_dir_order in the step config, such that an user have control for the ordering without needing to change the step 😄 What do you think about this? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.