Skip to content

feat: steps prepend their install directories to the PATH - #17

Open
code-steadfast wants to merge 1 commit into
cuinixam:mainfrom
code-steadfast:feature/prepend-install-directories
Open

code-steadfast wants to merge 1 commit into
cuinixam:mainfrom
code-steadfast:feature/prepend-install-directories

Conversation

@code-steadfast

Copy link
Copy Markdown
Contributor

No description provided.

@cuinixam

cuinixam commented Sep 8, 2026

Copy link
Copy Markdown
Owner

I do not think this is flexible enough to cover different use cases from the users. With such a change we only solve the current problem we have with the venv paths to be found before the user python paths.

I would suggest we take a more generic approach:

  • add include dirs takes either Path or IncludeDir class which has both the path and an integer for ordering.
  • if the user provides a path, we automatically create an IncludeDir with ordering 50
  • zero means left, meaning found first in PATH

The paths registered with the same order shall keep the order of when they were registered. For example, three paths A,B,C registered with order 13 will be put in the list based on the order number but keep the ordering A, B, C.

CreateVEnv can register its paths with 0.

We can also consider to have the include_dir_order in the step config, such that an user have control for the ordering without needing to change the step 😄

What do you think about this?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants