Keycloak reconfig - #16
Merged
Merged
Conversation
- Return a typed errAccessDenied sentinel from authenticateAndAuthorize instead of a one-off fmt.Errorf string. The test now uses errors.Is rather than substring-matching the error message, per CLAUDE.md guidance to avoid string-matching errors. - Extract the OAuth-callback admin-flag computation into a small computeIsAdmin method on *VICEProxy and add table-driven unit tests covering matching/non-matching/empty/missing-claim cases. Closes the test coverage gap on the callback site (previously only the per-request authenticateAndAuthorize path was covered). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for allowing admins into a running analysis.