Add dcos-autoscaler package - #1030
Conversation
|
@jeorg84 can you please take a look at this? |
ryadav88
left a comment
ryadav88
left a comment
There was a problem hiding this comment.
Please add an example documentation by creating a PR against the https://github.com/dcos/examples repo. See other examples there for reference. This is also now a requirement for submitting packages to Universe.
| "maintainer": "ahmadhassan612@gmail.com", | ||
| "description": "Adds autoscaling to your application based on cpu and memory metrics", | ||
| "scm": "https://github.com/Ahmadposten/DC-OS-Marathon-autoscaling", | ||
| "framework": true, |
There was a problem hiding this comment.
framework should be false
| "description": "Adds autoscaling to your application based on cpu and memory metrics", | ||
| "scm": "https://github.com/Ahmadposten/DC-OS-Marathon-autoscaling", | ||
| "framework": true, | ||
| "tags": ["autoscaling", "mesosphere", "dcos"], |
There was a problem hiding this comment.
mesosphere tag is reserved for packages developed by Mesosphere. Please remove it.
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
Add preInstallNotes and add this line at the beginning of preInstallNotes: This DC/OS Service is currently in preview. There may be bugs, incomplete features, incorrect documentation, or other discrepancies. Preview packages should never be used in production!
There was a problem hiding this comment.
Add a link to dcos/examples at the end of preInstallNotes
There was a problem hiding this comment.
@ryadav88 done .. please review again
here is the pull request for the examples repo dcos/examples#170
| "name": "dcos-autoscaler", | ||
| "version": "1.0.0", | ||
| "maintainer": "ahmadhassan612@gmail.com", | ||
| "description": "Adds autoscaling to your application based on cpu and memory metrics", |
There was a problem hiding this comment.
Add a detailed description of what the package does, what it be used for.
| "scm": "https://github.com/Ahmadposten/DC-OS-Marathon-autoscaling", | ||
| "framework": true, | ||
| "tags": ["autoscaling", "mesosphere", "dcos"], | ||
| "postInstallNotes": "Thank you for installing dcos autoscaler, Consult github.com/Ahmadposten/DC-OS-Marathon-autoscaling for more more info on usage and tuning configurations" |
There was a problem hiding this comment.
Add the license property.
| "assets": { | ||
| "container": { | ||
| "docker": { | ||
| "23b1cfe8e04a": "ahmadposten/dcos-autoscaler" |
There was a problem hiding this comment.
use a tagged version of the image
4 participants
Adding package dcos-autoscaler to universe.
This package provides service autoscaling based on cpu or memory. Every app autoscaling behavior is configurable using labels similar to how marathon load balancer works.