Conversation
Owner
Author
|
Opening this change against the upstream openshift/cluster-ingress-operator repository instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
AzureWorkloadIdentityfeature-gate dependency from thecluster ingress operator.
The feature is GA and enabled by default, so the previously gated Azure
workload identity behavior is now unconditional when no client secret is
available.
Changes include:
Why is this needed?
This must merge before
openshift/api#3018, which removes the feature-gatedefinition. Remaining
.Enabled()consumers would panic once the gate isremoved from the cluster-served feature-gate list.
Related: