Add embargo_end_date field to Dandiset model#2731
Merged
Merged
Conversation
jjnesbitt
force-pushed
the
dandiset-embargo-end-date
branch
2 times, most recently
from
f15f5fb to
9119727
Compare
jjnesbitt
force-pushed
the
dandiset-embargo-end-date
branch
from
9b1d78d to
2582261
Compare
This was referenced Mar 17, 2026
waxlamp
approved these changes
Apr 1, 2026
waxlamp
approved these changes
Apr 6, 2026
jjnesbitt
added
minor
Member
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2730
Closes #1286
Closes #2116
Supersedes #2729
This PR creates a field on the Dandiset model directly, to store the embargo end date for embargoed dandisets. This massively improves the ergonomics around embargoed dandisets, as now, we can guarantee that an embargoed dandiset has an embargo end date, at the database level. It also removes the ability for a user to change the embargo end date, which was easily accomplished via a PUT request. Now, the
embargoedUntilmetadata field is populated from the dandisetembargo_end_datefield.This also has additional ramifications for asset metadata. Now we can guarantee that if an embargoed asset is associated with any versions, it will have an embargoed end date.