Skip to content

fix: portable mod.nu path in tests, recommend mod.nu in README #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbodnar merged 3 commits into from
Mar 23, 2026
Merged

fix: portable mod.nu path in tests, recommend mod.nu in README #2

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85f79bb
Initial plan
Copilot Mar 21, 2026
6c3dff3
fix: dynamic mod.nu path in tests, recommend mod.nu in README
Copilot Mar 21, 2026
5cba432
fix(tests): rename mod-path to mod_path for snake_case consistency
Copilot Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ nupm install --path .

Clone the repo, then add to `config.nu`:

```nushell
use /path/to/dagger.nu/mod.nu *
```

Or, if you prefer to load only the completions file directly:

```nushell
use /path/to/dagger.nu/completions/dagger.nu *
```
Expand Down
3 changes: 2 additions & 1 deletion tests/completions.test.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,9 @@ def "test no duplicate externs" [] {
def "test mod.nu entry point" [] {
# Verify the root mod.nu re-exports everything from completions/
# We load it in a subshell to get an isolated scope reading
let mod-path = ([$env.FILE_PWD ".." "mod.nu"] | path join | path expand)
let out = ^nu --no-config-file -c $"
use '/workspaces/code/github.com/danielbodnar/dagger.nu/mod.nu' *
use '($mod-path)' *

Copilot AI Mar 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new variable name mod-path is inconsistent with the rest of this test file, which uses snake_case (e.g., all_tests). Consider renaming to mod_path (and updating the interpolation) for consistency and to avoid any potential parsing ambiguity around - in variable references.

Copilot uses AI. Check for mistakes.
scope commands | where name =~ '^dagger' | get name | to json
" | from json
assert ($out | is-not-empty) "mod.nu must re-export dagger commands"
Expand Down
Loading