Update to analysis_common_envelope#591
Merged
Merged
Conversation
…n energy calculation
Collaborator
Author
|
The test suite caught a bug with the cons2prim test. There was an issue because I have lumped some changes to entropy calculation in this pull request. Namely, I have ensured that any temperature solving uses the gas constant, |
Owner
|
See comment on splash PR, would be better to use .cols file which is an existing splash feature |
Owner
|
Also the cons2prim stuff should be pretty well unit tested so happy to approve that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is time to update this analysis module.
Changes to analysis_common_envelope:
Changes to other parts of Phantom:
entropyineosmodule: Add option to specify radiation temperature directly, which is useful if using radiation and Trad is stored.radiation_utils: RedefineradE_from_Trad(output is energy per unit volume) toradxi_from_Trad(output is energy per unit mass), the latter being more useful. Likewise, the inverse function is also changed fromTrad_from_radEtoTrad_from_rhoxi. The rest of the code has been adjusted to be consistent with these new definitions.eos_idealplusrad: Add functions to calculate gas energy and radiation energy separately.