fix: Add cookie chunking for iron-session - #944
Closed
ThomasGross wants to merge 1 commit into
Closed
Conversation
The Unilogin session (access + refresh + id token) overflows the 4096 byte browser cookie limit, breaking sign-in. Wrap iron-session's exported sealData/unsealData and split the seal across go-session.0, go-session.1, ... when it would otherwise exceed the limit. Mirrors the approach in the unmerged upstream PR vvo/iron-session#937 so we can drop the wrapper once that lands.
Contributor
|
Closing in favour of #943 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
no issue
Description
The Unilogin session (access + refresh + id token) overflows the 4096 byte browser cookie limit, breaking sign-in. Wrap iron-session's exported sealData/unsealData and split the seal across go-session.0, go-session.1, ... when it would otherwise exceed the limit. Mirrors the approach in the unmerged upstream PR vvo/iron-session#937 so we can drop the wrapper once that lands.