[Backport release-1.18] when_all waits for all tasks before surfacing the first failure - #1175
Merged
Merged
Conversation
Previously a WhenAllTask completed as soon as one child failed, while sibling tasks were still running and their later completions were dropped. Now the composite stages the first failure and keeps waiting; it completes only once every child has finished, then fails with the first recorded exception (or returns the ordered results if none failed). Signed-off-by: Albert Callarisa <albert@diagrid.io> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> (cherry picked from commit 47f0f23) Signed-off-by: dapr-bot <dapr-bot@users.noreply.github.com>
acroca
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 47f0f23 from #1166.