[ffigen] Add initial C++ scope support#3446
Draft
jakobkordez wants to merge 5 commits into
Draft
Conversation
Contributor
Author
|
@liamappelbe Mind looking at this and giving your opinion before I proceed with full support? |
Contributor
|
@jakobkordez Thanks for the PR, but C++ in FFIgen is a GSoC project. That is, it's a special project being worked on by a student at the moment. So we can't really accept external contributions to it currently. If you're still interested after GSoC is finished (in a few months) we'd be happy to accept PRs at that time. If you want something to work on in the meantime, you can take a look at the good-first-issues. Btw, a lot of those may appear to be claimed by other external devs, but afaik they've all gone dormant, so feel free to grab whatever looks interesting to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for scoped (for now only) enums. That is enums declared within namespaces, classes or structs.
Related Issues
None
PR Checklist
dart tool/ci.dart --alllocally and resolved all issues identified. This ensures the PR is formatted, has no lint errors, and ran all code generators. This applies to the packages part of the toplevelpubspec.yamlworkspace.CHANGELOG.mdfor the relevant packages. (Not needed for small changes such as doc typos).