refactor(rpc, wallet): address review feedback on provider transaction foundation

[PastaPastaPasta]

Issue being fixed or feature implemented

Addresses non-blocking code review feedback from knst on merged PR #7600 (typed provider transaction foundation).

What was done?

• Removed unused headers <deploymentstatus.h> and <evo/specialtx.h> from src/rpc/evo.cpp.
• Sorted headers alphabetically in src/wallet/test/wallet_tests.cpp.
• Consolidated ToggleFailBatch / ToggleFailDatabase with FailBatch / FailDatabase in src/wallet/test/wallet_tests.cpp to reuse a single database test fixture across interface_coin_lock_failed_persist and wallet_sync_tx_invalid_state_test.

How Has This Been Tested?

• Compiled src/test/test_dash with the depends toolchain.
• Passed wallet_tests Boost test suite.
• Passed evo_netinfo_tests Boost test suite.
• Passed lint-includes.py, lint-circular-dependencies.py, and lint-whitespace.py static linters.

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[thepastaclaw]

✅ Final review complete — no blockers (commit a1de5f6)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eb159ad8-d528-402d-9ad3-2c8dc62930ec

📥 Commits

Reviewing files that changed from the base of the PR and between 12f5ba2 and a1de5f6.

📒 Files selected for processing (2)

• src/rpc/evo.cpp
• src/wallet/test/wallet_tests.cpp

💤 Files with no reviewable changes (1)

• src/rpc/evo.cpp

Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review.

---

Walkthrough

The change removes unused headers from the Evo RPC source. Wallet tests now use shared FailBatch and FailDatabase mocks with a pass/fail state across database operations. The coin-lock persistence failure test uses the new mock and verifies failed and successful persistence paths. Duplicate mock definitions are removed, and wallet test includes are reordered.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a1de5

This PR makes localized cleanup and test-fixture refactoring changes without identified production behavior or merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: thepastaclaw

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 6.90% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the refactoring in RPC and wallet code and links it to review feedback on the provider transaction foundation.
Description check	✅ Passed	The description directly explains the header cleanup, include sorting, test fixture consolidation, and validation performed for this changeset.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

Final validation — Codex/Sol only (Phase 2 disabled)

At exact head a1de5f6, the fixture consolidation preserves both wallet tests' required pass/fail behavior, and the include cleanup introduces no correctness issue. The proposed commit-subject finding is not actionable because the body permanently records the technical changes and equivalent review-follow-up subjects are established in Dash history; no in-scope findings remain.
Source: reviewer backend for codex general: gpt-5.6-sol; reviewer backend for codex dash-core-commit-history: gpt-5.6-sol; final verifier backend: gpt-5.6-sol. openclaw-agent/cliproxy/gpt-5.6-sol is orchestration-only and not reviewer evidence.

Validated zero-blocker Codex/Sol precheck evidence was promoted to final because Phase 2 (Sonnet/Opus) is temporarily disabled. This is Codex/Sol-only final validation, not Codex + Sonnet/Opus coverage.

Review provenance

• Codex reviewers: gpt-5.6-sol — general (completed), gpt-5.6-sol — dash-core-commit-history (completed)
• Verifier: gpt-5.6-sol — verifier
• Sonnet/Opus: not run (Phase 2 disabled — temporary Codex/Sol-only final)
• Secondary pass: disabled (temporary_phase2_sonnet_disable)