Skip to content

feat(dpp): unify JSON/Value conversion traits + comprehensive round-trip tests #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shumkov wants to merge 150 commits into
base: v3.1-dev
Choose a base branch
from

docs(platform-value): correct to_value doctest after Critical-2

5ae8c26
Select commit
Loading
Failed to load commit list.
Open

feat(dpp): unify JSON/Value conversion traits + comprehensive round-trip tests #3573

docs(platform-value): correct to_value doctest after Critical-2
5ae8c26
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 1, 2026 in 1s

87.33% (+0.17%) compared to 12fd1a3

View this Pull Request on Codecov

87.33% (+0.17%) compared to 12fd1a3

Details

Codecov Report

❌ Patch coverage is 95.32520% with 207 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.33%. Comparing base (12fd1a3) to head (5ae8c26).
⚠️ Report is 37 commits behind head on v3.1-dev.

Files with missing lines Patch % Lines
...ages/rs-dpp/src/serialization/json/safe_integer.rs 22.79% 105 Missing ⚠️
packages/rs-dpp/src/serialization/serde_bytes.rs 78.75% 17 Missing ⚠️
...s/rs-dpp/src/data_contract/conversion/serde/mod.rs 82.45% 10 Missing ⚠️
...ckages/rs-dpp/src/serialization/serde_bytes_var.rs 63.63% 8 Missing ⚠️
packages/rs-dpp/src/state_transition/mod.rs 95.59% 7 Missing ⚠️
...ed_transition/document_create_transition/v0/mod.rs 86.00% 7 Missing ⚠️
...ackages/rs-dpp/src/data_contract/factory/v0/mod.rs 70.00% 6 Missing ⚠️
...ges/rs-dpp/src/data_contract/v0/conversion/json.rs 0.00% 6 Missing ⚠️
...kages/rs-dpp/src/document/extended_document/mod.rs 95.65% 5 Missing ⚠️
...es/rs-dpp/src/data_contract/conversion/json/mod.rs 50.00% 4 Missing ⚠️
... and 18 more
Additional details and impacted files 
@@             Coverage Diff              @@
##           v3.1-dev    #3573      +/-   ##
============================================
+ Coverage     87.16%   87.33%   +0.17%     
============================================
  Files          2607     2601       -6     
  Lines        319420   322859    +3439     
============================================
+ Hits         278413   281982    +3569     
+ Misses        41007    40877     -130
Components Coverage Δ
dpp 88.31% <95.32%> (+0.64%) ⬆️
drive 85.95% <ø> (+<0.01%) ⬆️
drive-abci 89.60% <ø> (-0.01%) ⬇️
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value 92.77% <ø> (+0.60%) ⬆️
platform-wallet ∅ <ø> (∅)
drive-proof-verifier 49.16% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov