-
Notifications
You must be signed in to change notification settings - Fork 55
fix(sdk): wallet-flow network fixes for SwiftExampleApp #3772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
QuantumExplorer
wants to merge
17
commits into
v3.1-dev
Choose a base branch
from
fix/swift-wallet-flow-network-fixes
base: v3.1-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
cea465e
fix(sdk): wallet-flow network fixes for SwiftExampleApp
QuantumExplorer ee59225
fix(sdk): per-network wallet persistence and add-to-network support
QuantumExplorer 207b4f8
fix(sdk): address review — network-scope deletes, surface errors, rea…
QuantumExplorer 65807e7
fix(sdk): drop identifier shortcut in hasAnyPrivateKey (review)
QuantumExplorer 076c0a0
fix(sdk): network-scope deriveAndStoreIdentityKey wallet lookup (review)
QuantumExplorer cee4b2c
fix(sdk): surface partial-failure in multi-network wallet create (rev…
QuantumExplorer 815751a
fix(sdk): correct two review-fix regressions (review)
QuantumExplorer 14d353e
fix(sdk): network-scoped walletId closes cross-network cache leak (#2)
QuantumExplorer 5e76921
test(sdk): cover all four networks in scoped-walletId stability test
QuantumExplorer 7f14210
fix(sdk): add walletGroupId so Wallet Info finds sibling-network wallets
QuantumExplorer 92b6b28
refactor(sdk): tighten PersistentWallet uniqueness to walletId alone
QuantumExplorer 795284a
Merge remote-tracking branch 'origin/v3.1-dev' into fix/swift-wallet-…
QuantumExplorer 4bdc604
refactor(sdk): drop dead predicate(walletId:network:) overload
QuantumExplorer dc55e6d
fix(sdk): use target-network birthHeight in enableNetwork metadata
QuantumExplorer 4cf30a4
fix(swift): scope resumable asset locks to active network
QuantumExplorer 1c0fb97
fix(sdk): classify duplicate-wallet errors by typed FFI code
QuantumExplorer 21391d5
fix(sdk): emit WalletAlreadyExists on duplicate create; scope restora…
QuantumExplorer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.