Skip to content

ci(swift-sdk): remove swift-sdk artifact upload#3778

Open
ZocoLini wants to merge 1 commit into
v3.1-devfrom
ci/drop-swift-artifact-upload
Open

ci(swift-sdk): remove swift-sdk artifact upload#3778
ZocoLini wants to merge 1 commit into
v3.1-devfrom
ci/drop-swift-artifact-upload

Conversation

@ZocoLini
Copy link
Copy Markdown
Collaborator

@ZocoLini ZocoLini commented Jun 1, 2026

it looks like nobody is using this artifact, and building it on every CI run makes no sense, it takes a lot of time from the CI pipeline. It makes more sense to build an artifact on release

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Simplified the Swift SDK build workflow to focus on test execution, removing post-build artifact packaging, distribution, and automated PR update mechanisms.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 122136ec-834d-4de8-8218-9eda54729e88

📥 Commits

Reviewing files that changed from the base of the PR and between 2a78c32 and 910c81b.

📒 Files selected for processing (1)
  • .github/workflows/swift-sdk-build.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/swift-sdk-build.yml

📝 Walkthrough

Walkthrough

The Swift SDK build workflow is simplified to remove post-build artifact packaging, checksum computation, artifact upload, and PR comment creation. The workflow now executes only the test script for the Swift SDK.

Changes

Swift SDK Workflow Simplification

Layer / File(s) Summary
Test execution only
.github/workflows/swift-sdk-build.yml
The workflow step executes bash packages/swift-sdk/run_tests.sh without the downstream artifact packaging, checksum computation, upload, and PR comment update steps that previously followed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • shumkov
  • QuantumExplorer

Poem

🐰 A workflow so streamlined and lean,
Test scripts now reign supreme, serene.
No zips, no checksums, no fuss,
Just tests running swift as a plus!
Simplicity's the name of the game.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci(swift-sdk): remove swift-sdk artifact upload' directly and accurately summarizes the main change - removing artifact upload from the Swift SDK CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/drop-swift-artifact-upload

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZocoLini ZocoLini force-pushed the ci/drop-swift-artifact-upload branch from 109b58c to 910c81b Compare June 1, 2026 21:57
@ZocoLini ZocoLini marked this pull request as ready for review June 1, 2026 23:25
@ZocoLini ZocoLini requested a review from QuantumExplorer as a code owner June 1, 2026 23:25
@ZocoLini ZocoLini requested a review from llbartekll June 1, 2026 23:25
@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented Jun 1, 2026

✅ Review complete (commit 910c81b)

Copy link
Copy Markdown
Collaborator

@thepastaclaw thepastaclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

PR cleanly simplifies the swift-sdk CI workflow by removing artifact zipping, checksum computation, upload, and PR comment steps while preserving the build+test step. No agent or CodeRabbit findings to verify, and the change matches the stated goal.

@QuantumExplorer
Copy link
Copy Markdown
Member

That the framework is buildable is part of CI (and I think it only happens if it is something that could affect iOS no longer being able to be built - granted that is a lot). While the upload isn't necessary, I was going to leave it until iOS was out.

@ZocoLini
Copy link
Copy Markdown
Collaborator Author

ZocoLini commented Jun 2, 2026

We can leave it until the release for sure, about the compilation, yeah, CI always compiles the sdk and executes the tests (the example app unit tests), the issue with the artifact upload is that it is huge in size, last time I checked it was around 2G in debug mode for the simulator lib, and the CI is building macOS, iOS and sim (in release it is around 150 MB, still a lot but better), that is what I wanted to cut off with his PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants