ci(swift-sdk): remove swift-sdk artifact upload#3778
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Swift SDK build workflow is simplified to remove post-build artifact packaging, checksum computation, artifact upload, and PR comment creation. The workflow now executes only the test script for the Swift SDK. ChangesSwift SDK Workflow Simplification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
109b58c to
910c81b
Compare
|
✅ Review complete (commit 910c81b) |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
PR cleanly simplifies the swift-sdk CI workflow by removing artifact zipping, checksum computation, upload, and PR comment steps while preserving the build+test step. No agent or CodeRabbit findings to verify, and the change matches the stated goal.
|
That the framework is buildable is part of CI (and I think it only happens if it is something that could affect iOS no longer being able to be built - granted that is a lot). While the upload isn't necessary, I was going to leave it until iOS was out. |
|
We can leave it until the release for sure, about the compilation, yeah, CI always compiles the sdk and executes the tests (the example app unit tests), the issue with the artifact upload is that it is huge in size, last time I checked it was around 2G in debug mode for the simulator lib, and the CI is building macOS, iOS and sim (in release it is around 150 MB, still a lot but better), that is what I wanted to cut off with his PR |
it looks like nobody is using this artifact, and building it on every CI run makes no sense, it takes a lot of time from the CI pipeline. It makes more sense to build an artifact on release
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit