Skip to content

Replace DaskJob pod with Kubernetes Job - #745

Open
Matt711 wants to merge 2 commits into
dask:mainfrom
Matt711:k8s-job
Open

Replace DaskJob pod with Kubernetes Job#745
Matt711 wants to merge 2 commits into
dask:mainfrom
Matt711:k8s-job

Conversation

@Matt711

@Matt711 Matt711 commented Jun 27, 2023

Copy link
Copy Markdown
Member

Closes #695. This PR replaces the Pod created from a DaskJob CRD with a Job. This allows us to use some of the existing functionality of K8s Jobs.

@bstadlbauer

bstadlbauer commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

Hey @Matt711!
Would you mind if I try whether things still work with the Flyte dask plugin (this thing) once you're ready?
It makes some assumptions around the job here, in particular the job-runner pod name, etc. So would be nice if this wouldn't be breaking the plugin

cc @jacobtomlinson

@Matt711

Matt711 commented Jun 27, 2023

Copy link
Copy Markdown
Member Author

Hey @Matt711! Would you mind if I try whether things still work with the Flyte dask plugin (this thing) once you're ready? It makes some assumptions around the job here, in particular the job-runner pod name, etc. So would be nice if this wouldn't be breaking the plugin

cc @jacobtomlinson

Yeah, no problem!

@Matt711
Matt711 marked this pull request as ready for review June 27, 2023 17:23
@Matt711
Matt711 requested a review from jacobtomlinson as a code owner June 27, 2023 17:23
"apiVersion": "batch/v1",
"kind": "Job",
"metadata": metadata,
"spec": {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want our spec to replace this, rather than the "spec" within "template".

That does mean we need to modify our CRDs to ref a JobSpec instead. That is a breaking change to our CRDs so we might need to think about how to bump the version there.

$ref: 'python://k8s_crd_resolver/schemata/k8s-1.21.1.json#/definitions/io.k8s.api.core.v1.PodSpec'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add backoffLimit to DaskJobs

3 participants