-
Notifications
You must be signed in to change notification settings - Fork 201
Allow configuring cascade deletion in DABs
#5846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
7b28c18
7df2def
9a2436c
5021a52
cb61ad7
423ca32
35d64f9
c59d737
c8cbb9b
6ff85f1
9b80091
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,5 +28,8 @@ | |
| "databricks.yml", | ||
| "databricks.yaml", | ||
| ] | ||
| }, | ||
| "files.watcherExclude": { | ||
| "**/target": true | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -57,7 +57,7 @@ The following resources will be deleted: | |||||
| delete resources.pipelines.pipeline1 | ||||||
|
|
||||||
| This action will result in the deletion of the following Lakeflow Spark Declarative Pipelines along with the | ||||||
| Streaming Tables (STs) and Materialized Views (MVs) managed by them: | ||||||
| Streaming Tables (STs) and Materialized Views (MVs) managed by them. Set 'cascade_on_destroy: false' on a pipeline to retain datasets on pipeline deletion: | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
datasets seems like a vague term to use here? In the context of dashboards, for example, this just means a SQL query. I could be wrong about this, so if this is standard for pipelines, feel free to keep it as is.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We generally use datasets in pipelines docs now, since pipeline-owned tables have been changing recently. Now, we also allow users to create Views in pipelines. In the near future, we plan to switch to creating regular delta tables as well. |
||||||
| delete resources.pipelines.pipeline1 | ||||||
|
|
||||||
| All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle-[UNIQUE_NAME]/default | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2273,6 +2273,7 @@ resources.models.*.permissions[*].service_principal_name string ALL | |
| resources.models.*.permissions[*].user_name string ALL | ||
| resources.pipelines.*.allow_duplicate_names bool ALL | ||
| resources.pipelines.*.budget_policy_id string ALL | ||
| resources.pipelines.*.cascade_on_destroy *bool ALL | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's odd that it's marked as "ALL" here. The ALL means that it present in input, state and remote types, but this field is absent from remote type. |
||
| resources.pipelines.*.catalog string ALL | ||
| resources.pipelines.*.cause string REMOTE | ||
| resources.pipelines.*.channel string ALL | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| bundle: | ||
| name: test-cascade-on-destroy-tf-error | ||
| resources: | ||
| pipelines: | ||
| my_pipeline: | ||
| name: test-pipeline-cascade-tf | ||
| cascade_on_destroy: false |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.