testserver: roll task outcomes up into the run state - #6082
Merged
radakam merged 2 commits intoJul 28, 2026
Merged
Conversation
The fake workspace reported every run as TERMINATED SUCCESS, overwriting the FAILED state it had just recorded for a task it executed locally. Runs now report the outcome their tasks add up to, so job_runs/failed_run can exercise a real failing run instead of stubbing runs/get through test.toml. Tasks whose code the fake workspace does not have (an immutable deployment uploads a snapshot zip it never unpacks) are left successful: that gap is in the fake workspace, not in the job under test.
radakam
marked this pull request as ready for review
July 28, 2026 08:40
radakam
merged commit Jul 28, 2026
ef276f9
into
job-runs-idempotency-wait-for-completion
23 checks passed
Contributor
Approval status: pending
|
radakam
added a commit
that referenced
this pull request
Jul 28, 2026
The fake workspace reported every run as TERMINATED SUCCESS, overwriting the FAILED state it had just recorded for a task it executed locally. A run now reports the terminal state its tasks add up to, so a failing run can be exercised end to end locally. Tasks whose code the fake workspace does not have are left successful. An immutable deployment, for example, uploads the bundle as a snapshot zip that the fake workspace never unpacks, so there is nothing to execute; that gap is in the fake workspace, not in the job under test. Originally reviewed as #6082.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The fake workspace reported every run as
TERMINATED SUCCESS, overwriting theFAILEDstate it had just recorded for a task it executed locally. A run now reports the terminal state its tasks add up to.Tasks whose code the fake workspace does not have are left successful. An immutable deployment, for example, uploads the bundle as a snapshot zip that the fake workspace never unpacks, so there is nothing to execute; that gap is in the fake workspace, not in the job under test.
With that,
job_runs/failed_rundrops theruns/getandruns/get-outputstubs from itstest.tomland fails for real, on a task that exits non-zero.Why
Follow-up to #5882, where a stub stood in for a failing run because the fake workspace could not produce one. Splitting it out keeps the behaviour change for existing tests out of that PR.
The stub could not know the test server's address, so it could not report a run page URL; the golden now covers the run URL and the progress lines too.
Tests
libs/testserverunit tests for the rollup, for completing the tasks that jobs/runs/submit leaves running, and for a task whose code is missing not failing its run.job_runs/failed_runcovers the end-to-end path. The rest of the acceptance suite passes unchanged.