refactor(seed): Refactor much of the codebase to setup seed#171
Open
david-bretaud-dev wants to merge 14 commits into
Open
refactor(seed): Refactor much of the codebase to setup seed#171david-bretaud-dev wants to merge 14 commits into
david-bretaud-dev wants to merge 14 commits into
Conversation
Collaborator
|
sorry, but it's a lot for me to review, when I don't know the codebase yet. If it'(s OK, I prefer to let you review @arnaudfnr for this one |
b884717 to
5c681b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Still manage one codebase but be able to develop (and deploy here) the 2 websites (seed and all4trees).
The main benefit is that we don't have to recreate an application or manage duplicates.
What I wanted to do here:
Normally, both apps are isolated and
The only thing that will problematic is
Highlight
Path
1 index.html -> 1 main.tsx -> 1 global-router which creates the 2 segments, and each app is lazy loaded.