rename: module path github.com/apache/spark-connect-go → github.com/caldempsey/spark-connect-go - #1
Merged
Merged
Conversation
Declares the module as github.com/caldempsey/spark-connect-go, drops the /v40 suffix, and updates every import in the tree to match. Consumers that want the fork's in-flight fixes no longer need a replace directive in their go.mod — go get against the caldempsey path resolves directly. Rebases against upstream stay mechanical: merge upstream in, sed module paths, resolve in the usual spots.
caldempsey
force-pushed
the
rename-module-path
branch
from
April 19, 2026 14:02
c591494 to
cdc2625
Compare
caldempsey
added a commit
that referenced
this pull request
Apr 19, 2026
…-go (#1) Declares the module as github.com/caldempsey/spark-connect-go, drops the /v40 suffix, and updates every import in the tree to match. Consumers that want the fork's in-flight fixes no longer need a replace directive in their go.mod — go get against the caldempsey path resolves directly. Rebases against upstream stay mechanical: merge upstream in, sed module paths, resolve in the usual spots.
caldempsey
added a commit
that referenced
this pull request
Apr 20, 2026
The previous main drifted 116 commits behind apache/spark-connect-go through a mis-sequenced merge. callum/SPARK-52780 is strictly ahead (21 commits over apache/master, 0 behind) and is the correct base for the fork going forward. This commit collapses every fork-side change that sat on top of the old main into a single squash, parented to callum/SPARK-52780, so the fork is once again strictly ahead of apache/master. Squashed content: - refactor/7: rename module path to github.com/caldempsey/spark-connect-go (#1) - fix/5: run build workflow on push to main (#6) - fix/8: fall back to archive.apache.org when dlcdn 404s (#9) - fix/2: strip DEBUG stdout prints from the ExecutePlan loop (#10) - feat/3: expose gRPC transport options on the channel + session builders (#11) - feat/4: add typed DataFrame[T] (#12) - docs/13: drop upstream "not for production" notice from fork README (#14) - feat: top-level typed helpers + Dataset[T] alias (#15) - chore: rename module path to github.com/datalakego/spark-connect-go (#16) - feat: Dataset[T].Where / Limit / OrderBy / First / Stream methods (#17) - feat: SqlAs[T] + TableAs[T] free functions; SqlTyped deprecated (#18) - feat: ErrClusterNotReady + IsClusterNotReady + NewClusterNotReady (#19) - feat: database/sql driver over Spark Connect (#20) - refactor: trim typed API to edge-wrapper shape only (#21) - feat: parameter binding + drop format DSN param from database/sql driver (#22) - refactor: rename org github.com/datalakego → github.com/datalake-go (#23) Follow-up: port the NewRowSequence / iter.Seq2 polish from the callum/SPARK-52780 branch forward — this squash takes the older channel-based RowIterator shape from main. See the callum/SPARK-52780 branch for the polished version that came out of upstream PR review.
caldempsey
added a commit
that referenced
this pull request
Apr 20, 2026
…-go (#1) Declares the module as github.com/caldempsey/spark-connect-go, drops the /v40 suffix, and updates every import in the tree to match. Consumers that want the fork's in-flight fixes no longer need a replace directive in their go.mod — go get against the caldempsey path resolves directly. Rebases against upstream stay mechanical: merge upstream in, sed module paths, resolve in the usual spots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the module declaration from
github.com/apache/spark-connect-gotogithub.com/caldempsey/spark-connect-goand update every import statement in the tree to match.Why
The fork carries local changes that haven't landed upstream yet (streaming reads per SPARK-52780, configurable gRPC transport, typed row accessors — see the sibling issues). Consuming the fork under the upstream module path forces every downstream project into a
replacedance in theirgo.mod, which leaks the fork as an implementation detail into every consumer.Renaming the module path makes the fork self-identifying:
Go resolves the default branch automatically on first use; consumers pin via pseudo-version or tag exactly as they would for any other module.
Does this PR introduce any user-facing change?
Yes — every existing import needs the same search-and-replace consumers did:
(Note: also drops the
/v40major-version suffix; the fork ships unversioned until it's worth cutting tagged releases.)Rebasing against upstream
Stays mechanical: pull upstream into a merge branch, run a single
sedover module paths, resolve conflicts in the usual spots. Cheaper than the perpetual replace-directive tax on every downstream project.