Skip to content

Progress - Complete the bars of 9 more commands in finally blocks (tier 2) #10774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreasjordan wants to merge 9 commits into
base: development
Choose a base branch
from
Open

Progress - Complete the bars of 9 more commands in finally blocks (tier 2) #10774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
af4bd12
Invoke-DbaAdvancedRestore - Complete the progress bars in finally blocks
andreasjordan Oct 5, 2026
b091d7f
Read-DbaBackupHeader - Complete the progress bar in a finally block
andreasjordan Oct 5, 2026
70e776a
Invoke-DbaDiagnosticQuery - Complete the progress bar in a finally block
andreasjordan Oct 5, 2026
e19bc2b
Start-DbaMigration - Complete the progress bar in a finally block
andreasjordan Oct 5, 2026
8cfac21
Sync-DbaAvailabilityGroup - Complete the progress bar in a finally block
andreasjordan Oct 5, 2026
8c0b8f0
Export-DbaUser - Complete the progress bar in a finally block
andreasjordan Oct 5, 2026
e23288f
Invoke-DbaDbDataGenerator - Complete the progress bar in a finally block
andreasjordan Oct 5, 2026
3df9e38
Invoke-DbaDbPiiScan - Complete the progress bar in a finally block
andreasjordan Oct 5, 2026
8a05b63
Expand-DbaDbLogFile - Complete the progress bars in finally blocks
andreasjordan Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
517 changes: 263 additions & 254 deletions public/Expand-DbaDbLogFile.ps1
View file
Open in desktop

Large diffs are not rendered by default.

597 changes: 300 additions & 297 deletions public/Export-DbaUser.ps1
View file
Open in desktop

Large diffs are not rendered by default.

559 changes: 282 additions & 277 deletions public/Invoke-DbaAdvancedRestore.ps1
View file
Open in desktop

Large diffs are not rendered by default.

581 changes: 292 additions & 289 deletions public/Invoke-DbaDbDataGenerator.ps1
View file
Open in desktop

Large diffs are not rendered by default.

369 changes: 186 additions & 183 deletions public/Invoke-DbaDbPiiScan.ps1
View file
Open in desktop

Large diffs are not rendered by default.

347 changes: 174 additions & 173 deletions public/Invoke-DbaDiagnosticQuery.ps1
View file
Open in desktop

Large diffs are not rendered by default.

73 changes: 38 additions & 35 deletions public/Read-DbaBackupHeader.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,47 +334,50 @@ function Read-DbaBackupHeader {
Write-Message -Level Warning -Message "File $file does not exist or access denied. The SQL Server service account may not have access to the source directory."
}
}
#receive runspaces
while ($threads | Where-Object { $_.isRetrieved -eq $false }) {
$totalThreads = ($threads | Measure-Object).Count
$totalRetrievedThreads = ($threads | Where-Object { $_.isRetrieved -eq $true } | Measure-Object).Count
Write-Progress -Id 1 -Activity Updating -Status 'Progress' -CurrentOperation "Scanning Restore headers: $totalRetrievedThreads/$totalThreads" -PercentComplete ($totalRetrievedThreads / $totalThreads * 100)
foreach ($thread in ($threads | Where-Object { $_.isRetrieved -eq $false })) {
if ($thread.Handle.IsCompleted) {
$dataTable = $thread.thread.EndInvoke($thread.handle)
$thread.isRetrieved = $true
#Check if thread had any errors
if ($thread.thread.HadErrors) {
if ($thread.deviceType -eq 'FILE') {
Stop-Function -Message "Problem found with $($thread.file)." -Target $thread.file -ErrorRecord $thread.thread.Streams.Error -Continue
} else {
Stop-Function -Message "Unable to read $($thread.file), check credential $StorageCredential and network connectivity." -Target $thread.file -ErrorRecord $thread.thread.Streams.Error -Continue
try {
#receive runspaces
while ($threads | Where-Object { $_.isRetrieved -eq $false }) {
$totalThreads = ($threads | Measure-Object).Count
$totalRetrievedThreads = ($threads | Where-Object { $_.isRetrieved -eq $true } | Measure-Object).Count
Write-Progress -Id 1 -Activity Updating -Status 'Progress' -CurrentOperation "Scanning Restore headers: $totalRetrievedThreads/$totalThreads" -PercentComplete ($totalRetrievedThreads / $totalThreads * 100)
foreach ($thread in ($threads | Where-Object { $_.isRetrieved -eq $false })) {
if ($thread.Handle.IsCompleted) {
$dataTable = $thread.thread.EndInvoke($thread.handle)
$thread.isRetrieved = $true
#Check if thread had any errors
if ($thread.thread.HadErrors) {
if ($thread.deviceType -eq 'FILE') {
Stop-Function -Message "Problem found with $($thread.file)." -Target $thread.file -ErrorRecord $thread.thread.Streams.Error -Continue
} else {
Stop-Function -Message "Unable to read $($thread.file), check credential $StorageCredential and network connectivity." -Target $thread.file -ErrorRecord $thread.thread.Streams.Error -Continue
}
}
}
#Process the result of this thread

$dbVersion = $dataTable[0].DatabaseVersion
$SqlVersion = (Convert-DbVersionToSqlVersion $dbVersion)
foreach ($row in $dataTable) {
$row.SqlVersion = $SqlVersion
if ($row.BackupName -eq "*** INCOMPLETE ***") {
Stop-Function -Message "$($thread.file) appears to be from a new version of SQL Server than $SqlInstance, skipping" -Target $thread.file -Continue
#Process the result of this thread

$dbVersion = $dataTable[0].DatabaseVersion
$SqlVersion = (Convert-DbVersionToSqlVersion $dbVersion)
foreach ($row in $dataTable) {
$row.SqlVersion = $SqlVersion
if ($row.BackupName -eq "*** INCOMPLETE ***") {
Stop-Function -Message "$($thread.file) appears to be from a new version of SQL Server than $SqlInstance, skipping" -Target $thread.file -Continue
}
}
if ($Simple) {
$dataTable | Select-Object DatabaseName, BackupFinishDate, RecoveryModel, BackupSize, CompressedBackupSize, DatabaseCreationDate, UserName, ServerName, SqlVersion, BackupPath
} elseif ($FileList) {
$dataTable.filelist
} else {
$dataTable
}
}
if ($Simple) {
$dataTable | Select-Object DatabaseName, BackupFinishDate, RecoveryModel, BackupSize, CompressedBackupSize, DatabaseCreationDate, UserName, ServerName, SqlVersion, BackupPath
} elseif ($FileList) {
$dataTable.filelist
} else {
$dataTable
}

$thread.thread.Dispose()
$thread.thread.Dispose()
}
}
Start-Sleep -Milliseconds 500
}
Start-Sleep -Milliseconds 500
} finally {
Write-Progress -Id 1 -Activity Updating -Completed
}
Write-Progress -Id 1 -Activity Updating -Completed
#Close the runspace pool
$runspacePool.Close()
[System.Management.Automation.Runspaces.Runspace]::DefaultRunspace = $defaultrunspace
Expand Down
Loading
Loading