Repository navigation
Get-AgentJobFingerprint - Store the file with LF line endings - #10783
Open
andreasjordan wants to merge 1 commit into
Open
andreasjordan wants to merge 1 commit into
andreasjordan wants to merge 1 commit into
Conversation
The file came in with CRLF line endings in the repository (#10767). .gitattributes declares *.ps1 as text, so git compares the working file normalized to LF against the CRLF blob, and the file shows as modified in every clone. git restore cannot clear it, and it blocks switching to branches that do not have the file. This renormalizes the blob to LF. The content is unchanged: the diff is empty with --ignore-cr-at-eol. It was the only text file in the repository stored with CRLF. (do Copy-DbaAgentJob) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andreasjordan
marked this pull request as ready for review
October 11, 2026 14:30
potatoqualitee
approved these changes
Oct 12, 2026
potatoqualitee
left a comment
Member
There was a problem hiding this comment.
Reviewed at ca3a99a. No material defect found.
Verified the complete patch and raw Git blobs: the only change is normalization of 117 CRLF line endings to LF. The blobs are otherwise byte-for-byte identical, and the diff is empty with --ignore-cr-at-eol. This matches the existing *.ps1 text attribute. Fingerprint separators are explicit string escapes, so their values are unchanged.
Checked the Copy-DbaAgentJob call sites, existing behavioral coverage, and discussions. All 20 executed head checks passed, including the Azure COPY matrix; one Windows test check was skipped. No additional tests are needed for the verified content-preserving normalization. Pester was not rerun locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
private/functions/Get-AgentJobFingerprint.ps1came in with #10767 and is stored in the repository with CRLF line endings.git ls-files --eolshows it asi/crlf ... attr/text..gitattributesdeclares*.ps1astext, so git normalizes the working file to LF before it compares it with the blob. The CRLF blob never matches, so the file shows as modified (117 lines changed, 117 removed) in every fresh clone and checkout:git restoreandgit checkout --write the CRLF blob back, and the file is immediately "modified" again.git add -Aorgit commit -apicks it up by accident.Change
git add --renormalize private/functions/Get-AgentJobFingerprint.ps1, which stores the blob with LF like every other.ps1file. The content is unchanged:git diff --ignore-cr-at-eolis empty. It was the only file with thetextattribute stored with CRLF;git ls-files --eolnow lists none.Tests
No code changes, so no new tests. The commit carries
(do Copy-DbaAgentJob), the only command that uses this helper.馃 Generated with Claude Code