Build RRA with the portable c++ compiler driver#5
Merged
Conversation
The RRA Makefile hardcoded CC = g++, so installation failed on systems that provide only clang++ (no g++ on PATH), even though the docs state a generic C++ compiler is sufficient (flagged in mageck2-doc PR #3 review). Default to the portable 'c++' driver, which resolves to g++ on Linux and clang++ on macOS; it can still be overridden via 'make CC=...'. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Codex review on mageck2-doc#3 correctly flagged that the RRA
MakefilehardcodedCC = g++. On a system that provides onlyclang++(nog++onPATH),pip installwould fail at the RRA build step — even though the docs say a generic C++ compiler is sufficient. (It only worked on macOS becauseg++there is a clang shim.)Fix
Change the Makefile default to the portable
c++driver, which resolves tog++on Linux andclang++on macOS. It can still be overridden, e.g.make CC=g++.This makes the "a C++ compiler" prerequisite in the README and INSTALL docs actually true, rather than a g++-only requirement.
Testing
Verified
make CC=c++builds RRA, and a fullpip installfrom a clean clone on Python 3.13 plus an end-to-endmageck2 testrun (100-gene gene_summary) all succeed. CI exercises both the Linux (c++→g++) and macOS (c++→clang++) paths.