fix: strip inline-comment marks before markdown conversion - #71
Closed
danielphan2003 wants to merge 1 commit into
Closed
danielphan2003 wants to merge 1 commit into
danielphan2003 wants to merge 1 commit into
Conversation
get_document failed on documents with inline comments because @hcengineering/text-markdown has no serializer for the inline-comment mark. Strip those marks before serialization while preserving the highlighted text; thread metadata remains available via list_inline_comments.
danielphan2003
force-pushed
the
fix/inline-comment-markdown
branch
from
May 28, 2026 04:16
a9550a4 to
6088b83
Compare
dearlordylord
self-requested a review
May 28, 2026 04:45
Owner
|
@danielphan2003 thank you for finding the issue and bringing it to attention. It's likely upstream problem - I opened a PR hcengineering/huly.core#19 as to the PR, I'll use it as an inspiration for local huly-mcp fix; I can't merge it as-is (see what stripInlineCommentMarks does with its argument and with its return, and see how stripInlineCommentMarks usage line names its argument and its return) but the finding is very valuable - thank you for that again |
Owner
|
superseeded by #72 thank you again for pointing the issue and the initial cause analysis @danielphan2003 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_document(and allfetchMarkupmarkdown paths) failing withNo info for mark inline-commentwhen document content contains Huly inline commentsinline-commentProseMirror marks before@hcengineering/text-markdownserialization while preserving the highlighted textlist_inline_commentstoolTest plan
pnpm check-allpasses (2130 tests)test/huly/operations/markup.test.tsfor mark stripping and markdown serializationget_documentagainst a document with inline comments (teamspaceProduct Owner, doc6a100d4f8cc535985f7d2678) returns full markdown contentMade with Cursor