Skip to content

debezium/dbz#1809 Standardize Examples — Offset Editor - #499

Merged
Naros merged 2 commits into
debezium:mainfrom
samson30:dbz-1809-offset-editor
Oct 16, 2026
Merged

Naros merged 2 commits into
debezium:mainfrom
samson30:dbz-1809-offset-editor

Conversation

@samson30

Copy link
Copy Markdown
Contributor

Relates to debezium/dbz#1809

Description

Standardizes offset-editor.

  • Uses debezium-examples-parent as parent, so the Java version (21) now comes from the root POM instead of the local Java 11 maven.compiler.source/target settings
  • Upgrades JavaFX 16 → 21.0.7, the JavaFX line built for Java 21 (JavaFX 16 is no longer supported)
  • Upgrades maven-shade-plugin 3.2.4 → 3.6.0, which supports Java 21 class files
  • Updates the README prerequisites to JDK 21 and JavaFX 21
  • groupId/artifactId/version are unchanged, so the jar names stay the same

There is no CI workflow for this example, so I verified it locally on JDK 21: mvn clean install succeeds, mvn javafx:run opens the editor, and the shaded jar (java -jar target/offset-editor-1.0-SNAPSHOT-shaded.jar) starts the GUI.

Checklist

  • If the changes include a new example, I added it to the list of examples in the README.md file

Signed-off-by: samson30 <60385580+samson30@users.noreply.github.com>

@Naros Naros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR LGTM, I've just left one small item below on a README change.

Comment thread offset-editor/README.md Outdated
Signed-off-by: samson30 <60385580+samson30@users.noreply.github.com>
@Naros
Naros merged commit 4914789 into debezium:main Oct 16, 2026
1 check passed
@Naros

Naros commented Oct 16, 2026

Copy link
Copy Markdown
Member

Thanks @samson30, applied! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants