Skip to content

feat: billboard target entity #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pravusjif merged 6 commits into from
Jul 9, 2026
Merged

feat: billboard target entity #1445

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
96ddf82
removed unneeded test
pravusjif Jul 2, 2026
413be0b
update protocol + add test
pravusjif Jul 3, 2026
5c22758
package update and rebuilt snapshots
pravusjif Jul 7, 2026
4370072
updated protocol package
pravusjif Jul 8, 2026
4769e4e
Revert "removed unneeded test"
pravusjif Jul 8, 2026
5bfa2af
rebuilt snapshots
pravusjif Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"bugs": "https://github.com/decentraland/js-sdk-toolchain/issues",
"dependencies": {
"@actions/core": "^1.10.0",
"@dcl/protocol": "1.0.0-28050011172.commit-c96236d",
"@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz",
Comment thread
pravusjif marked this conversation as resolved.
Outdated
"@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1",
"@dcl/ts-proto": "1.153.0",
"@types/fs-extra": "^9.0.12",
Expand Down
4 changes: 3 additions & 1 deletion packages/@dcl/playground-assets/etc/playground-assets.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ export const AvatarModifierArea: LastWriteWinElementSetComponentDefinition<PBAva
// @public (undocumented)
export const enum AvatarModifierType {
AMT_DISABLE_PASSPORTS = 1,
AMT_HIDE_AVATARS = 0
AMT_HIDE_AVATARS = 0,
AMT_HIDE_NAMETAGS = 2
Comment thread
pravusjif marked this conversation as resolved.
}

// @public (undocumented)
Expand Down Expand Up @@ -2618,6 +2619,7 @@ export namespace PBAvatarShape {
// @public (undocumented)
export interface PBBillboard {
billboardMode?: BillboardMode | undefined;
targetEntity?: number | undefined;
}

// @public (undocumented)
Expand Down
8 changes: 4 additions & 4 deletions packages/@dcl/sdk-commands/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@dcl/sdk-commands/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@dcl/inspector": "7.34.3",
"@dcl/linker-dapp": "0.15.2",
"@dcl/mini-comms": "1.0.1-20230216163137.commit-a4c75be",
"@dcl/protocol": "1.0.0-28050011172.commit-c96236d",
"@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-28905497157.commit-85548e4.tgz",
"@dcl/quests-client": "^1.0.3",
"@dcl/quests-manager": "^0.1.4",
"@dcl/rpc": "^1.1.1",
Expand Down
23 changes: 22 additions & 1 deletion test/ecs/components/Billboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,28 @@ describe('Generated Billboard ProtoBuf', () => {
const Billboard = components.Billboard(newEngine)

testComponentSerialization(Billboard, {
billboardMode: BillboardMode.BM_Y
billboardMode: BillboardMode.BM_Y,
targetEntity: undefined
})
})

it('should serialize/deserialize Billboard with targetEntity', () => {
const newEngine = Engine()
const Billboard = components.Billboard(newEngine)

testComponentSerialization(Billboard, {
billboardMode: BillboardMode.BM_Y,
targetEntity: 512
})
})

it('should serialize/deserialize Billboard without targetEntity', () => {
const newEngine = Engine()
const Billboard = components.Billboard(newEngine)

testComponentSerialization(Billboard, {
billboardMode: BillboardMode.BM_ALL,
targetEntity: undefined
})
})
})
42 changes: 0 additions & 42 deletions test/sdk-commands/commands/start/explorer-alpha.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,48 +143,6 @@ describe('explorer-alpha', () => {
})
})

describe('multiInstance parameter', () => {
it('should include multi-instance parameter when --multi-instance flag is provided', async () => {
Comment thread
pravusjif marked this conversation as resolved.
const args: any = {
'--multi-instance': true
}

await runExplorerAlpha(mockComponents, {
cwd: '/test',
realm: 'test-realm',
baseCoords: { x: 0, y: 0 },
isHub: false,
args
})

expect(mockExec).toHaveBeenCalledWith(
'/test',
'open',
expect.arrayContaining([expect.stringContaining('multi-instance=true')]),
{ silent: true }
)
})

it('should not include multi-instance parameter when --multi-instance flag is not provided', async () => {
const args: any = {}

await runExplorerAlpha(mockComponents, {
cwd: '/test',
realm: 'test-realm',
baseCoords: { x: 0, y: 0 },
isHub: false,
args
})

expect(mockExec).toHaveBeenCalledWith(
'/test',
'open',
expect.arrayContaining([expect.not.stringContaining('multi-instance')]),
{ silent: true }
)
})
})

describe('URL parameter construction', () => {
it('should construct URL with all parameters correctly', async () => {
const args: any = {
Expand Down
6 changes: 3 additions & 3 deletions test/snapshots/development-bundles/static-scene.test.ts.crdt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SCENE_COMPILED_JS_SIZE_PROD=565k bytes
SCENE_COMPILED_JS_SIZE_PROD=565.4k bytes
THE BUNDLE HAS SOURCEMAPS
(start empty vm 0.21.0-3680274614.commit-1808aa1)
OPCODES ~= 0k
Expand All @@ -12,7 +12,7 @@ EVAL test/snapshots/development-bundles/static-scene.test.js
REQUIRE: ~system/EngineApi
REQUIRE: ~system/Runtime
OPCODES ~= 73k
MALLOC_COUNT = 16304
MALLOC_COUNT = 16305
ALIVE_OBJS_DELTA ~= 3.24k
CALL onStart()
main.crdt: PUT_COMPONENT e=0x200 c=1 t=0 data={"position":{"x":5.880000114440918,"y":2.7916901111602783,"z":7.380000114440918},"rotation":{"x":0,"y":0,"z":0,"w":1},"scale":{"x":1,"y":1,"z":1},"parent":0}
Expand Down Expand Up @@ -57,4 +57,4 @@ CALL onUpdate(0.1)
OPCODES ~= 5k
MALLOC_COUNT = -5
ALIVE_OBJS_DELTA ~= 0.00k
MEMORY_USAGE_COUNT ~= 1427.87k bytes
MEMORY_USAGE_COUNT ~= 1428.31k bytes
6 changes: 3 additions & 3 deletions test/snapshots/development-bundles/testing-fw.test.ts.crdt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SCENE_COMPILED_JS_SIZE_PROD=565.5k bytes
SCENE_COMPILED_JS_SIZE_PROD=565.9k bytes
THE BUNDLE HAS SOURCEMAPS
(start empty vm 0.21.0-3680274614.commit-1808aa1)
OPCODES ~= 0k
Expand All @@ -12,7 +12,7 @@ EVAL test/snapshots/development-bundles/testing-fw.test.js
REQUIRE: ~system/EngineApi
REQUIRE: ~system/Runtime
OPCODES ~= 83k
MALLOC_COUNT = 16856
MALLOC_COUNT = 16857
ALIVE_OBJS_DELTA ~= 3.40k
CALL onStart()
LOG: ["Adding one to position.y=0"]
Expand Down Expand Up @@ -63,4 +63,4 @@ CALL onUpdate(0.1)
OPCODES ~= 6k
MALLOC_COUNT = -53
ALIVE_OBJS_DELTA ~= -0.01k
MEMORY_USAGE_COUNT ~= 1433.63k bytes
MEMORY_USAGE_COUNT ~= 1434.07k bytes
6 changes: 3 additions & 3 deletions test/snapshots/development-bundles/two-way-crdt.test.ts.crdt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SCENE_COMPILED_JS_SIZE_PROD=565.5k bytes
SCENE_COMPILED_JS_SIZE_PROD=565.9k bytes
THE BUNDLE HAS SOURCEMAPS
(start empty vm 0.21.0-3680274614.commit-1808aa1)
OPCODES ~= 0k
Expand All @@ -12,7 +12,7 @@ EVAL test/snapshots/development-bundles/two-way-crdt.test.js
REQUIRE: ~system/EngineApi
REQUIRE: ~system/Runtime
OPCODES ~= 83k
MALLOC_COUNT = 16856
MALLOC_COUNT = 16857
ALIVE_OBJS_DELTA ~= 3.40k
CALL onStart()
LOG: ["Adding one to position.y=0"]
Expand Down Expand Up @@ -63,4 +63,4 @@ CALL onUpdate(0.1)
OPCODES ~= 6k
MALLOC_COUNT = -53
ALIVE_OBJS_DELTA ~= -0.01k
MEMORY_USAGE_COUNT ~= 1433.64k bytes
MEMORY_USAGE_COUNT ~= 1434.08k bytes
2 changes: 1 addition & 1 deletion test/snapshots/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions test/snapshots/production-bundles/append-value-crdt.ts.crdt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SCENE_COMPILED_JS_SIZE_PROD=248.5k bytes
SCENE_COMPILED_JS_SIZE_PROD=248.6k bytes
(start empty vm 0.21.0-3680274614.commit-1808aa1)
OPCODES ~= 0k
MALLOC_COUNT = 1005
Expand All @@ -10,7 +10,7 @@ EVAL test/snapshots/production-bundles/append-value-crdt.js
REQUIRE: ~system/EngineApi
REQUIRE: ~system/Runtime
OPCODES ~= 85k
MALLOC_COUNT = 15164
MALLOC_COUNT = 15165
ALIVE_OBJS_DELTA ~= 3.40k
CALL onStart()
Renderer: APPEND_VALUE e=0x200 c=1063 t=0 data={"button":0,"hit":{"position":{"x":1,"y":2,"z":3},"globalOrigin":{"x":1,"y":2,"z":3},"direction":{"x":1,"y":2,"z":3},"normalHit":{"x":1,"y":2,"z":3},"length":10,"meshName":"mesh","entityId":512},"state":1,"timestamp":1,"analog":5,"tickNumber":0}
Expand Down Expand Up @@ -56,4 +56,4 @@ CALL onUpdate(0.1)
OPCODES ~= 15k
MALLOC_COUNT = 31
ALIVE_OBJS_DELTA ~= 0.01k
MEMORY_USAGE_COUNT ~= 1069.95k bytes
MEMORY_USAGE_COUNT ~= 1070.25k bytes
6 changes: 3 additions & 3 deletions test/snapshots/production-bundles/billboard.ts.crdt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SCENE_COMPILED_JS_SIZE_PROD=289.3k bytes
SCENE_COMPILED_JS_SIZE_PROD=289.5k bytes
(start empty vm 0.21.0-3680274614.commit-1808aa1)
OPCODES ~= 0k
MALLOC_COUNT = 1005
Expand All @@ -10,7 +10,7 @@ EVAL test/snapshots/production-bundles/billboard.js
REQUIRE: ~system/EngineApi
REQUIRE: ~system/Runtime
OPCODES ~= 87k
MALLOC_COUNT = 17681
MALLOC_COUNT = 17683
ALIVE_OBJS_DELTA ~= 3.87k
CALL onStart()
OPCODES ~= 0k
Expand Down Expand Up @@ -78,4 +78,4 @@ CALL onUpdate(0.1)
OPCODES ~= 12k
MALLOC_COUNT = 0
ALIVE_OBJS_DELTA ~= 0.00k
MEMORY_USAGE_COUNT ~= 1255.93k bytes
MEMORY_USAGE_COUNT ~= 1256.31k bytes
6 changes: 3 additions & 3 deletions test/snapshots/production-bundles/cube-deleted.ts.crdt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SCENE_COMPILED_JS_SIZE_PROD=244.7k bytes
SCENE_COMPILED_JS_SIZE_PROD=244.9k bytes
(start empty vm 0.21.0-3680274614.commit-1808aa1)
OPCODES ~= 0k
MALLOC_COUNT = 1005
Expand All @@ -10,7 +10,7 @@ EVAL test/snapshots/production-bundles/cube-deleted.js
REQUIRE: ~system/EngineApi
REQUIRE: ~system/Runtime
OPCODES ~= 76k
MALLOC_COUNT = 14284
MALLOC_COUNT = 14285
ALIVE_OBJS_DELTA ~= 3.17k
CALL onStart()
OPCODES ~= 0k
Expand Down Expand Up @@ -43,4 +43,4 @@ CALL onUpdate(0.1)
OPCODES ~= 6k
MALLOC_COUNT = 1
ALIVE_OBJS_DELTA ~= 0.00k
MEMORY_USAGE_COUNT ~= 1032.22k bytes
MEMORY_USAGE_COUNT ~= 1032.52k bytes
6 changes: 3 additions & 3 deletions test/snapshots/production-bundles/cube.ts.crdt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SCENE_COMPILED_JS_SIZE_PROD=244.6k bytes
SCENE_COMPILED_JS_SIZE_PROD=244.7k bytes
(start empty vm 0.21.0-3680274614.commit-1808aa1)
OPCODES ~= 0k
MALLOC_COUNT = 1005
Expand All @@ -10,7 +10,7 @@ EVAL test/snapshots/production-bundles/cube.js
REQUIRE: ~system/EngineApi
REQUIRE: ~system/Runtime
OPCODES ~= 75k
MALLOC_COUNT = 14257
MALLOC_COUNT = 14258
ALIVE_OBJS_DELTA ~= 3.16k
CALL onStart()
OPCODES ~= 0k
Expand All @@ -33,4 +33,4 @@ CALL onUpdate(0.1)
OPCODES ~= 3k
MALLOC_COUNT = 0
ALIVE_OBJS_DELTA ~= 0.00k
MEMORY_USAGE_COUNT ~= 1021.97k bytes
MEMORY_USAGE_COUNT ~= 1022.28k bytes
6 changes: 3 additions & 3 deletions test/snapshots/production-bundles/cubes.ts.crdt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SCENE_COMPILED_JS_SIZE_PROD=289.7k bytes
SCENE_COMPILED_JS_SIZE_PROD=289.9k bytes
(start empty vm 0.21.0-3680274614.commit-1808aa1)
OPCODES ~= 0k
MALLOC_COUNT = 1005
Expand All @@ -10,7 +10,7 @@ EVAL test/snapshots/production-bundles/cubes.js
REQUIRE: ~system/EngineApi
REQUIRE: ~system/Runtime
OPCODES ~= 127k
MALLOC_COUNT = 21018
MALLOC_COUNT = 21020
ALIVE_OBJS_DELTA ~= 5.16k
CALL onStart()
OPCODES ~= 0k
Expand Down Expand Up @@ -1653,4 +1653,4 @@ CALL onUpdate(0.1)
OPCODES ~= 725k
MALLOC_COUNT = 0
ALIVE_OBJS_DELTA ~= 0.00k
MEMORY_USAGE_COUNT ~= 1480.40k bytes
MEMORY_USAGE_COUNT ~= 1480.79k bytes
6 changes: 3 additions & 3 deletions test/snapshots/production-bundles/pointer-events.ts.crdt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SCENE_COMPILED_JS_SIZE_PROD=245.5k bytes
SCENE_COMPILED_JS_SIZE_PROD=245.7k bytes
(start empty vm 0.21.0-3680274614.commit-1808aa1)
OPCODES ~= 0k
MALLOC_COUNT = 1005
Expand All @@ -10,7 +10,7 @@ EVAL test/snapshots/production-bundles/pointer-events.js
REQUIRE: ~system/EngineApi
REQUIRE: ~system/Runtime
OPCODES ~= 77k
MALLOC_COUNT = 14550
MALLOC_COUNT = 14551
ALIVE_OBJS_DELTA ~= 3.24k
CALL onStart()
OPCODES ~= 0k
Expand Down Expand Up @@ -44,4 +44,4 @@ CALL onUpdate(0.1)
OPCODES ~= 3k
MALLOC_COUNT = 0
ALIVE_OBJS_DELTA ~= 0.00k
MEMORY_USAGE_COUNT ~= 1041.67k bytes
MEMORY_USAGE_COUNT ~= 1041.98k bytes
Loading
Loading