[dmt] Implemented gateway requirements#356
Merged
Merged
Conversation
332d459 to
21b70ac
Compare
Signed-off-by: Paramoshka <parfenov_ivan_42a@mail.ru>
62d5351 to
baef16c
Compare
…uire-httproute Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new
httproute-rulestemplate linter rule that enforces DKP's transitionto the Kubernetes Gateway API: any module shipping an
Ingressmust also ship afunctionally equivalent
HTTPRoute(matched byapplabel) whosespec.parentRefsreferences aListenerSetdefined in the same module.The rule reports:
applabel match),parentRefsis empty, andparentRefsdoes not reference any in-module ListenerSet.Every finding points authors to the network team for help with the migration.
Why
DKP is moving from Ingress-Nginx toward the Gateway API. During the transition
modules must work through both stacks simultaneously, so the linter now requires
the Gateway API counterpart to ship alongside each Ingress. Modules that comply
need no further changes when Ingress-Nginx is retired.