[dmt] deprecate disable.message in module.yaml in favor of disable.messages#411
Open
Fkuloff wants to merge 1 commit into
Open
[dmt] deprecate disable.message in module.yaml in favor of disable.messages#411Fkuloff wants to merge 1 commit into
Fkuloff wants to merge 1 commit into
Conversation
ipaqsa
approved these changes
Jun 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the definition-file module linter to treat disable.message in module.yaml as deprecated and instruct authors to migrate to localized disable.messages (en/ru), consistent with the existing description → descriptions.en deprecation flow.
Changes:
- Extends the
DeckhouseModuleYAML schema model with adisablesection (ModuleDisable,ModuleDisableMessages). - Adds a lint error/warning when deprecated
disable.messageis used, pointing todisable.messageswithru/en.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+298
to
+300
| if yml.Disable != nil && yml.Disable.Message != "" { | ||
| errorList.WithMaxLevel(maxLevel).Error("Field 'disable.message' is deprecated, use 'disable.messages' (with 'ru'/'en') instead") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
definition-filerule (module linter) now flags the deprecated singulardisable.messagefield inmodule.yamland points authors to the localizeddisable.messages(ru/en) instead — mirroring the existingdescription→descriptions.endeprecation (error for external modules, warning for in-repo Deckhouse modules). Deckhouse addeddisable.messages.{ru,en}so the console can render the disable-confirmation warning in the user's locale; the olddisable.messageis being phased out, and this lint forces module authors to migrate.