fix(vm): fix flap condition VirtualMachineIPAddressReady#2553
Merged
Conversation
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
bb00c39 to
492de69
Compare
yaroslavborbat
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The guest-agent merge in KubeVirt processed IPv4 and IPv6 independently and cleared the address of a family from the VMI interface status whenever the guest-agent reported no address for that family. When the guest transiently reported only a link-local address (e.g.
fe80::/10) or no address at all while the assigned IPv4 was being (re)acquired via DHCP, the pod-cache IPv4 was wiped from the status. Combined with the cache being repopulated on cycles without guest-agent data, the reported interface IP flapped between the assigned IPv4 and the IPv6 link-local address — which in turn flapped theVirtualMachineIPAddressReadycondition.With the bundled fix, guest-agent IP data augments, but never clears, the existing per-family address: an address already present in the status (originating from the pod cache) is kept even when the guest-agent reports none for that family.
Related: deckhouse/3p-kubevirt#135
Why do we need it, and what problem does it solve?
A VM whose guest reports only an IPv6 link-local address (no IPv4) caused the internal KubeVirt VMI status to flap between the assigned IPv4 and the link-local IPv6:
This flap propagated to the
VirtualMachineIPAddressReadycondition, which oscillated betweenTrueandFalse:The constant condition churn produces noisy transitions and events and makes the VM look unstable.
What is the expected result?
IPstays the assigned IPv4 andVirtualMachineIPAddressReadystaysTrue— no flapping.Checklist
Changelog entries