fix(api): make user-facing condition messages clearer

images/virtualization-artifact/pkg/controller/cvi/internal/image_presence.go

@@ -61,7 +61,7 @@ func (h *ImagePresenceHandler) Handle(ctx context.Context, cvi *v1alpha2.Cluster
 			Generation(cvi.Generation).
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.ImageLost).
-			Message(fmt.Sprintf("Image %q not found in DVCR.", registryURL))
+			Message("The image data is no longer available and needs to be recreated.")
 
 		conditions.SetCondition(cb, &cvi.Status.Conditions)
 	}

images/virtualization-artifact/pkg/controller/cvi/internal/source/http.go

@@ -136,7 +136,7 @@ func (ds HTTPDataSource) Sync(ctx context.Context, cvi *v1alpha2.ClusterVirtualI
 		cvi.Status.Phase = v1alpha2.ImageProvisioning
 		cb.Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("DVCR Provisioner not found: create the new one.")
+			Message("Preparing to import the image.")
 
 		log.Info("Create importer pod...", "progress", cvi.Status.Progress, "pod.phase", "nil")
 
@@ -207,7 +207,7 @@ func (ds HTTPDataSource) Sync(ctx context.Context, cvi *v1alpha2.ClusterVirtualI
 
 		cb.Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("Import is in the process of provisioning to DVCR.")
+			Message("The image is being imported.")
 
 		cvi.Status.Phase = v1alpha2.ImageProvisioning
 		cvi.Status.Progress = ds.statService.GetProgress(cvi.GetUID(), pod, cvi.Status.Progress)

images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref.go

@@ -205,7 +205,7 @@ func (ds ObjectRefDataSource) Sync(ctx context.Context, cvi *v1alpha2.ClusterVir
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("DVCR Provisioner not found: create the new one.")
+			Message("Preparing to import the image.")
 
 		log.Info("Ready", "progress", cvi.Status.Progress, "pod.phase", "nil")
 
@@ -245,7 +245,7 @@ func (ds ObjectRefDataSource) Sync(ctx context.Context, cvi *v1alpha2.ClusterVir
 			cb.
 				Status(metav1.ConditionFalse).
 				Reason(cvicondition.ProvisioningFailed).
-				Message("Failed to get stats from non-ready datasource: waiting for the DataSource to be ready.")
+				Message("Waiting for the source data to become ready.")
 			return reconcile.Result{}, nil
 		}
 
@@ -283,7 +283,7 @@ func (ds ObjectRefDataSource) Sync(ctx context.Context, cvi *v1alpha2.ClusterVir
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("Import is in the process of provisioning to DVCR.")
+			Message("The image is being imported.")
 
 		cvi.Status.Phase = v1alpha2.ImageProvisioning
 		cvi.Status.Target.RegistryURL = ds.statService.GetDVCRImageName(pod)

images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref_vd.go

@@ -136,7 +136,7 @@ func (ds ObjectRefVirtualDisk) Sync(ctx context.Context, cvi *v1alpha2.ClusterVi
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("DVCR Provisioner not found: create the new one.")
+			Message("Preparing to import the image.")
 
 		log.Info("Create importer pod...", "progress", cvi.Status.Progress, "pod.phase", "nil")
 
@@ -204,7 +204,7 @@ func (ds ObjectRefVirtualDisk) Sync(ctx context.Context, cvi *v1alpha2.ClusterVi
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("Import is in the process of provisioning to DVCR.")
+			Message("The image is being imported.")
 
 		cvi.Status.Phase = v1alpha2.ImageProvisioning
 		cvi.Status.Progress = ds.statService.GetProgress(cvi.GetUID(), pod, cvi.Status.Progress)

images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref_vdsnapshot.go

@@ -196,7 +196,7 @@ func (ds ObjectRefVirtualDiskSnapshot) Sync(ctx context.Context, cvi *v1alpha2.C
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(vicondition.Provisioning).
-			Message("PVC has created: waiting to be Bound.")
+			Message("Restoring data from the snapshot. Waiting for the PersistentVolumeClaim to be Bound.")
 
 		cvi.Status.Progress = "0%"
 		cvi.Status.SourceUID = ptr.To(vs.UID)
@@ -226,7 +226,7 @@ func (ds ObjectRefVirtualDiskSnapshot) Sync(ctx context.Context, cvi *v1alpha2.C
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(vicondition.Provisioning).
-			Message("DVCR Provisioner not found: create the new one.")
+			Message("Preparing to import the image.")
 
 		log.Info("Create importer pod...", "progress", cvi.Status.Progress, "pod.phase", "nil")
 
@@ -274,7 +274,7 @@ func (ds ObjectRefVirtualDiskSnapshot) Sync(ctx context.Context, cvi *v1alpha2.C
 					cb.
 						Status(metav1.ConditionFalse).
 						Reason(vicondition.Provisioning).
-						Message("Waiting for PVC to be bound")
+						Message("Restoring data from the snapshot. Waiting for the PersistentVolumeClaim to be Bound.")
 
 					return reconcile.Result{RequeueAfter: time.Second}, nil
 				}
@@ -304,7 +304,7 @@ func (ds ObjectRefVirtualDiskSnapshot) Sync(ctx context.Context, cvi *v1alpha2.C
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(vicondition.Provisioning).
-			Message("Import is in the process of provisioning to DVCR.")
+			Message("The image is being imported.")
 
 		cvi.Status.Phase = v1alpha2.ImageProvisioning
 		cvi.Status.Progress = ds.statService.GetProgress(cvi.GetUID(), pod, cvi.Status.Progress)

images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref_vi_on_pvc.go

@@ -125,7 +125,7 @@ func (ds ObjectRefVirtualImageOnPvc) Sync(ctx context.Context, cvi *v1alpha2.Clu
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("DVCR Provisioner not found: create the new one.")
+			Message("Preparing to import the image.")
 
 		log.Info("Create importer pod...", "progress", cvi.Status.Progress, "pod.phase", "nil")
 
@@ -193,7 +193,7 @@ func (ds ObjectRefVirtualImageOnPvc) Sync(ctx context.Context, cvi *v1alpha2.Clu
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("Import is in the process of provisioning to DVCR.")
+			Message("The image is being imported.")
 
 		cvi.Status.Phase = v1alpha2.ImageProvisioning
 		cvi.Status.Progress = ds.statService.GetProgress(cvi.GetUID(), pod, cvi.Status.Progress)

images/virtualization-artifact/pkg/controller/cvi/internal/source/registry.go

@@ -142,7 +142,7 @@ func (ds RegistryDataSource) Sync(ctx context.Context, cvi *v1alpha2.ClusterVirt
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("DVCR Provisioner not found: create the new one.")
+			Message("Preparing to import the image.")
 
 		log.Info("Create importer pod...", "progress", cvi.Status.Progress, "pod.phase", "nil")
 
@@ -212,7 +212,7 @@ func (ds RegistryDataSource) Sync(ctx context.Context, cvi *v1alpha2.ClusterVirt
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("Import is in the process of provisioning to DVCR.")
+			Message("The image is being imported.")
 
 		cvi.Status.Phase = v1alpha2.ImageProvisioning
 		cvi.Status.Progress = "0%"

images/virtualization-artifact/pkg/controller/cvi/internal/source/upload.go

@@ -151,7 +151,7 @@ func (ds UploadDataSource) Sync(ctx context.Context, cvi *v1alpha2.ClusterVirtua
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("DVCR Provisioner not found: create the new one.")
+			Message("Preparing to import the image.")
 
 		log.Info("Create uploader pod...", "progress", cvi.Status.Progress, "pod.phase", nil)
 
@@ -222,7 +222,7 @@ func (ds UploadDataSource) Sync(ctx context.Context, cvi *v1alpha2.ClusterVirtua
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.Provisioning).
-			Message("Import is in the process of provisioning to DVCR.")
+			Message("The image is being imported.")
 
 		cvi.Status.Phase = v1alpha2.ImageProvisioning
 		cvi.Status.Progress = ds.statService.GetProgress(cvi.GetUID(), pod, cvi.Status.Progress)
@@ -239,7 +239,7 @@ func (ds UploadDataSource) Sync(ctx context.Context, cvi *v1alpha2.ClusterVirtua
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(cvicondition.WaitForUserUpload).
-			Message("Waiting for the user upload.")
+			Message("Waiting for the user to upload image data.")
 
 		cvi.Status.Phase = v1alpha2.ImageWaitForUserUpload
 		cvi.Status.Target.RegistryURL = ds.statService.GetDVCRImageName(pod)

images/virtualization-artifact/pkg/controller/dvcr-garbage-collection/postponeimporter/postpone_handler.go

@@ -102,7 +102,7 @@ func (p *PostponeHandler[T]) Handle(ctx context.Context, obj T) (reconcile.Resul
 		cb := conditions.NewConditionBuilder(getReadyType(obj)).Generation(obj.GetGeneration())
 		cb.Status(metav1.ConditionFalse).
 			Reason(ProvisioningPostponedReason).
-			Message("DVCR is in garbage collection mode: wait until it finishes before creating provisioner.")
+			Message("DVCR is performing garbage collection. The operation is postponed and will continue automatically once it completes.")
 		conditions.SetCondition(cb, conditions.NewConditionsAccessor(obj).Conditions())
 	}
 	// Garbage collection enabled and resources are postponed: requeue to check garbage collection status later.

images/virtualization-artifact/pkg/controller/nodeusbdevice/internal/handler/attached.go

@@ -79,7 +79,7 @@ func (h *AttachedHandler) Handle(ctx context.Context, s state.NodeUSBDeviceState
 
 	attachedCondition := meta.FindStatusCondition(usbDevice.Status.Conditions, string(usbdevicecondition.AttachedType))
 	if attachedCondition == nil {
-		setAttachedCondition(current, &changed.Status.Conditions, metav1.ConditionFalse, nodeusbdevicecondition.AttachedAvailable, fmt.Sprintf("Attached condition not found in USBDevice %s/%s.", usbDevice.Namespace, usbDevice.Name))
+		setAttachedCondition(current, &changed.Status.Conditions, metav1.ConditionFalse, nodeusbdevicecondition.AttachedAvailable, fmt.Sprintf("Waiting for the attachment status of USBDevice %s/%s.", usbDevice.Namespace, usbDevice.Name))
 		return reconcile.Result{}, nil
 	}
 

images/virtualization-artifact/pkg/controller/nodeusbdevice/internal/handler/attached_test.go

@@ -106,6 +106,6 @@ var _ = Describe("AttachedHandler", func() {
 		}, metav1.ConditionFalse, string(nodeusbdevicecondition.NoFreeUSBIPPort), "No free USBIP ports are available."),
 		Entry("missing attached condition falls back to available", "test-ns", &v1alpha2.USBDevice{
 			ObjectMeta: metav1.ObjectMeta{Name: "usb-device-1", Namespace: "test-ns"},
-		}, metav1.ConditionFalse, string(nodeusbdevicecondition.AttachedAvailable), "Attached condition not found in USBDevice test-ns/usb-device-1."),
+		}, metav1.ConditionFalse, string(nodeusbdevicecondition.AttachedAvailable), "Waiting for the attachment status of USBDevice test-ns/usb-device-1."),
 	)
 })

images/virtualization-artifact/pkg/controller/service/size_policy_service.go

@@ -65,7 +65,7 @@ func (s *SizePolicyService) CheckVMMatchedSizePolicy(vm *v1alpha2.VirtualMachine
 	}
 
 	if len(errs) > 0 {
-		return fmt.Errorf("sizing policy validation has failed: %w: %w", errors.Join(errs...), ErrSizingPolicyValidation)
+		return fmt.Errorf("does not match the VirtualMachineClass sizing policy: %w: %w", errors.Join(errs...), ErrSizingPolicyValidation)
 	}
 
 	return nil

images/virtualization-artifact/pkg/controller/usbdevice/internal/handler/lifecycle.go

@@ -95,7 +95,7 @@ func (h *LifecycleHandler) syncReady(ctx context.Context, s state.USBDeviceState
 	}
 
 	if nodeUSBDevice == nil {
-		setReadyCondition(current, &changed.Status.Conditions, metav1.ConditionFalse, usbdevicecondition.NotFound, "Corresponding NodeUSBDevice not found.", nil)
+		setReadyCondition(current, &changed.Status.Conditions, metav1.ConditionFalse, usbdevicecondition.NotFound, "The USB device is no longer present on its node.", nil)
 		return nil
 	}
 
@@ -106,7 +106,7 @@ func (h *LifecycleHandler) syncReady(ctx context.Context, s state.USBDeviceState
 
 	readyCondition := meta.FindStatusCondition(nodeUSBDevice.Status.Conditions, string(nodeusbdevicecondition.ReadyType))
 	if readyCondition == nil {
-		setReadyCondition(current, &changed.Status.Conditions, metav1.ConditionFalse, usbdevicecondition.NotReady, "Ready condition not found in NodeUSBDevice.", nil)
+		setReadyCondition(current, &changed.Status.Conditions, metav1.ConditionFalse, usbdevicecondition.NotReady, "Waiting for the USB device readiness to be determined.", nil)
 		return nil
 	}
 
@@ -247,8 +247,8 @@ func (h *LifecycleHandler) syncAttached(ctx context.Context, s state.USBDeviceSt
 		}
 
 		if !hasFreePort {
-			message := fmt.Sprintf("Device is requested by VirtualMachine %s/%s, but no free USBIP ports are available on node %s for speed %d.",
-				vm.Namespace, vm.Name, vm.Status.Node, changed.Status.Attributes.Speed)
+			message := fmt.Sprintf("The USB device is requested by VirtualMachine %s/%s, but node %s has no free USB passthrough capacity for this device.",
+				vm.Namespace, vm.Name, vm.Status.Node)
 			setAttachedCondition(current, &changed.Status.Conditions, metav1.ConditionFalse, usbdevicecondition.NoFreeUSBIPPort, message)
 			return nil
 		}

images/virtualization-artifact/pkg/controller/vd/internal/life_cycle.go

@@ -128,7 +128,7 @@ func (h LifeCycleHandler) Handle(ctx context.Context, vd *v1alpha2.VirtualDisk)
 			cb.
 				Status(metav1.ConditionFalse).
 				Reason(vdcondition.StorageClassIsNotReady).
-				Message("Storage class is not ready.")
+				Message("The StorageClass is not ready.")
 			conditions.SetCondition(cb, &vd.Status.Conditions)
 
 			return reconcile.Result{}, nil

images/virtualization-artifact/pkg/controller/vd/internal/migration.go

@@ -492,13 +492,13 @@ func (h MigrationHandler) handleMigrateSync(ctx context.Context, vd *v1alpha2.Vi
 		Reason(vdcondition.MigratingWaitForTargetReadyReason)
 
 	if pvc == nil {
-		cb.Message("Target persistent volume claim is not found.")
+		cb.Message("The target PersistentVolumeClaim is not found.")
 		conditions.SetCondition(cb, &vd.Status.Conditions)
 		return nil
 	}
 
 	if pvc.Status.Phase == corev1.ClaimBound {
-		cb.Status(metav1.ConditionTrue).Reason(vdcondition.InProgress).Message("Target persistent volume claim is bound.")
+		cb.Status(metav1.ConditionTrue).Reason(vdcondition.InProgress).Message("The target PersistentVolumeClaim is Bound.")
 		conditions.SetCondition(cb, &vd.Status.Conditions)
 		return nil
 	}
@@ -509,7 +509,7 @@ func (h MigrationHandler) handleMigrateSync(ctx context.Context, vd *v1alpha2.Vi
 			storageClassName = *sc
 		}
 		if storageClassName == "" {
-			cb.Message("Target persistent volume claim is pending.")
+			cb.Message("The target PersistentVolumeClaim is pending.")
 			conditions.SetCondition(cb, &vd.Status.Conditions)
 			return nil
 		}
@@ -518,7 +518,7 @@ func (h MigrationHandler) handleMigrateSync(ctx context.Context, vd *v1alpha2.Vi
 		err = h.client.Get(ctx, types.NamespacedName{Name: storageClassName}, sc)
 		if err != nil {
 			if k8serrors.IsNotFound(err) {
-				cb.Message("Target persistent volume claim is pending, StorageClass is not found.")
+				cb.Message("The target PersistentVolumeClaim is pending; the StorageClass is not found.")
 				conditions.SetCondition(cb, &vd.Status.Conditions)
 				return nil
 			}
@@ -527,13 +527,13 @@ func (h MigrationHandler) handleMigrateSync(ctx context.Context, vd *v1alpha2.Vi
 
 		isWaitForFistConsumer := sc.VolumeBindingMode == nil || *sc.VolumeBindingMode == storagev1.VolumeBindingWaitForFirstConsumer
 		if isWaitForFistConsumer {
-			cb.Status(metav1.ConditionTrue).Reason(vdcondition.InProgress).Message("Target persistent volume claim is waiting for first consumer.")
+			cb.Status(metav1.ConditionTrue).Reason(vdcondition.InProgress).Message("The target PersistentVolumeClaim is waiting for the first consumer.")
 			conditions.SetCondition(cb, &vd.Status.Conditions)
 			return nil
 		}
 	}
 
-	cb.Message("Target persistent volume claim is not bound or not waiting for first consumer.")
+	cb.Message("Waiting for the target PersistentVolumeClaim to be provisioned.")
 	conditions.SetCondition(cb, &vd.Status.Conditions)
 	return nil
 }

images/virtualization-artifact/pkg/controller/vd/internal/resizing.go

@@ -214,7 +214,7 @@ func (h ResizingHandler) ResizeNeeded(
 		cb.
 			Status(metav1.ConditionFalse).
 			Reason(vdcondition.ResizingNotAvailable).
-			Message("Disk resizing is not allowed: Storage class is not ready")
+			Message("Disk resizing is not allowed: the StorageClass is not ready.")
 		conditions.SetCondition(cb, &vd.Status.Conditions)
 	}
 

images/virtualization-artifact/pkg/controller/vd/internal/source/http.go

@@ -259,7 +259,7 @@ func (ds HTTPDataSource) Sync(ctx context.Context, vd *v1alpha2.VirtualDisk) (re
 		}
 
 		vd.Status.Phase = v1alpha2.DiskProvisioning
-		setReadyConditionWithWFFCAccounting(vd, cb, metav1.ConditionFalse, vdcondition.Provisioning, "PVC Provisioner not found: create the new one.")
+		setReadyConditionWithWFFCAccounting(vd, cb, metav1.ConditionFalse, vdcondition.Provisioning, "Preparing the disk storage.")
 
 		return reconcile.Result{RequeueAfter: time.Second}, nil
 	case dvQuotaNotExceededCondition != nil && dvQuotaNotExceededCondition.Status == corev1.ConditionFalse:
@@ -279,7 +279,7 @@ func (ds HTTPDataSource) Sync(ctx context.Context, vd *v1alpha2.VirtualDisk) (re
 		return reconcile.Result{}, nil
 	case pvc == nil:
 		vd.Status.Phase = v1alpha2.DiskProvisioning
-		setReadyConditionWithWFFCAccounting(vd, cb, metav1.ConditionFalse, vdcondition.Provisioning, "PVC not found: waiting for creation.")
+		setReadyConditionWithWFFCAccounting(vd, cb, metav1.ConditionFalse, vdcondition.Provisioning, "Waiting for the PersistentVolumeClaim to be created.")
 		return reconcile.Result{RequeueAfter: time.Second}, nil
 	case ds.diskService.IsImportDone(dv, pvc):
 		log.Info("Import has completed", "dvProgress", dv.Status.Progress, "dvPhase", dv.Status.Phase, "pvcPhase", pvc.Status.Phase)

images/virtualization-artifact/pkg/controller/vd/internal/source/registry.go

@@ -264,7 +264,7 @@ func (ds RegistryDataSource) Sync(ctx context.Context, vd *v1alpha2.VirtualDisk)
 			return reconcile.Result{}, err
 		}
 		vd.Status.Phase = v1alpha2.DiskProvisioning
-		setReadyConditionWithWFFCAccounting(vd, cb, metav1.ConditionFalse, vdcondition.Provisioning, "PVC Provisioner not found: create the new one.")
+		setReadyConditionWithWFFCAccounting(vd, cb, metav1.ConditionFalse, vdcondition.Provisioning, "Preparing the disk storage.")
 
 		return reconcile.Result{RequeueAfter: time.Second}, nil
 	case dvQuotaNotExceededCondition != nil && dvQuotaNotExceededCondition.Status == corev1.ConditionFalse:
@@ -284,7 +284,7 @@ func (ds RegistryDataSource) Sync(ctx context.Context, vd *v1alpha2.VirtualDisk)
 		return reconcile.Result{}, nil
 	case pvc == nil:
 		vd.Status.Phase = v1alpha2.DiskProvisioning
-		setReadyConditionWithWFFCAccounting(vd, cb, metav1.ConditionFalse, vdcondition.Provisioning, "PVC not found: waiting for creation.")
+		setReadyConditionWithWFFCAccounting(vd, cb, metav1.ConditionFalse, vdcondition.Provisioning, "Waiting for the PersistentVolumeClaim to be created.")
 		return reconcile.Result{RequeueAfter: time.Second}, nil
 	case ds.diskService.IsImportDone(dv, pvc):
 		log.Info("Import has completed", "dvProgress", dv.Status.Progress, "dvPhase", dv.Status.Phase, "pvcPhase", pvc.Status.Phase)