multi: Use blake256.NewHasher256 instead of New#3735
Merged
Conversation
Callers should prefer NewHasher256 over New since it returns a concrete type that has more functionality and allows avoiding additional allocations.
davecgh
approved these changes
Jul 16, 2026
davecgh
left a comment
davecgh
left a comment
Member
There was a problem hiding this comment.
It won't really make any difference in these particular cases because it's only used with method that take a hash.Hash interface, but it's still a good idea.
Technically, those methods could type assert and be more efficient when they notice it's of the right type if they wanted to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers should prefer NewHasher256 over New since it returns a concrete type that has more functionality and allows avoiding additional allocations.