Repository navigation
Combine OCR and Molmo evidence for image chat - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ordinary image upload could enter the app's bounded
analysis_depth=fastpath, which disabled visual analysis and left the final text model with only an OCR status message. The image OCR bridge also expected a top-leveltextfield even though native Tesseract returns alinesarray, so successful OCR was reported as unavailable.Every image plan now gathers both literal OCR and visual evidence. The gateway joins Tesseract line objects into bounded text, invokes the installed visual specialist (preferring Molmo2), and sends separate
OCR:andMOLMO IMAGE DESCRIPTION:sections to the selected final chat model. Empty OCR and failed OCR remain distinct. Fast image handling stays bounded by using an overview Molmo pass; documents retain their existing fast reader behavior.Validation:
make testmake test-molmo2-gatewaymake ocr-test test-pdf-ocr-runtimenode tests/test_composer_ui.mjsnode tests/test_composer_perf.mjs