Skip to content

fix(setup): 权限数据范围自动收敛为「与应用的可用范围一致」，不再以「全部」提审 #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepcoldy merged 4 commits into from
Aug 28, 2026
Merged

fix(setup): 权限数据范围自动收敛为「与应用的可用范围一致」，不再以「全部」提审 #1061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ff6fa9
feat(setup): 自动把权限数据范围配成「与应用的可用范围一致」，不再留空提审
deepcoldy Aug 28, 2026
dd5cf06
fix(setup): 模板默认的「全部」数据范围也要收窄，否则新建 bot 照旧卡审批
deepcoldy Aug 28, 2026
e16308d
test(setup): 修 setup-pickers 的位置式 stub —— 数据范围收窄插了一步
deepcoldy Aug 28, 2026
f33e35e
fix(setup): 「已收敛」判据对齐 console 的 XC()——part 但 filters 为空也算未配置
deepcoldy Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/dashboard/bot-onboarding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1542,6 +1542,10 @@ export class BotOnboardingManager {
// 这份 ACK 是从权限台账重建的，本次并没有碰 redirect 白名单。宁可报「没配」
// 让人去核一眼，也不能凭空报「配好了」——那正是 20029 静默失败的来源。
redirectConfigured: false,
// 同上：本次没有读/写「权限可访问的数据范围」。0 + warning 才是诚实的
// 「没碰过」，报 0 而不带 warning 会被下游读成「本来就没有待配的」。
privilegeRangeCount: 0,
privilegeRangeWarning: '本次从权限台账重建，未读写权限数据范围',
eventMode: managedPermission.eventMode,
verifiedEventCount: managedPermission.verifiedEventCount,
versionId: managedPermission.versionId,
Expand Down
9 changes: 8 additions & 1 deletion src/im/lark/event-dispatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,15 @@ async function tryAutoFixScopes(
: '所有必需权限已在应用清单中';
// 一项都没申请上时，这次自愈**没有**修好任何东西，日志级别也不该是「succeeded」。
const autoFixEffective = result.scopeCount > 0 || (!result.scopeWarning && result.skippedScopeCount === 0);
// 数据范围只在**真做了事**或**真出错**时才进日志：常态是「没有待配的」，
// 那句话对读日志的人零信息量，还会淹没上面真正的 scope 结论。
const privilegeRangeDetail = result.privilegeRangeCount > 0
? `, ${result.privilegeRangeCount} 项权限数据范围已设为「与应用的可用范围一致」`
: result.privilegeRangeWarning
? `, 权限数据范围未能自动配置（${result.privilegeRangeWarning}）`
: '';
const summary =
`[${larkAppId}] auto-fix ${autoFixEffective ? 'succeeded' : 'could NOT apply the missing scopes'}: ${scopeDetail}, ` +
`[${larkAppId}] auto-fix ${autoFixEffective ? 'succeeded' : 'could NOT apply the missing scopes'}: ${scopeDetail}${privilegeRangeDetail}, ` +
`version ${result.versionId ?? 'n/a'} published, ` +
`${result.subscribedEventCount} events subscribed`;
if (autoFixEffective) logger.info(summary);
Expand Down
Loading