Repository navigation
fix!: pass variadic inputs in connection order in Pipeline.run() and run_async() #13415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c9bf0dc
adding test before the fix
davidsbatista 1d19ff3
WIP
davidsbatista 1d3fbc1
using connectiong order in variadic list
davidsbatista b531c00
wip
davidsbatista 72fc39b
Merge branch 'main' into fix/async-run-lazy-variadic-order
davidsbatista 1098898
nits
davidsbatista b858ab9
adding release notes
davidsbatista 3fecbaf
adding more tests to assert connection order is also variadic order
davidsbatista 8dfc97f
rename the test
davidsbatista cdf3b10
Merge branch 'main' into fix/async-run-lazy-variadic-order
davidsbatista b44c8bb
PR review: drop unreachable branch, trim tests, document weights orde…
davidsbatista File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
releasenotes/notes/lazy-variadic-inputs-connection-order-cb62f434b1878f8e.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| fixes: | ||
|
sjrl marked this conversation as resolved.
Resolved
|
||
| - | | ||
| Components with a ``Variadic`` input, or a ``list`` input connected to several senders, now receive the values | ||
| in the order the senders were connected with ``Pipeline.connect()``, in both ``Pipeline.run()`` and | ||
| ``Pipeline.run_async()``. Pipeline inputs passed directly to such a socket come first. | ||
| Before, ``Pipeline.run_async()`` passed the values in the order the senders finished, which could change between | ||
| runs, so ``DocumentJoiner`` could apply its ``weights`` to the wrong retriever. ``Pipeline.run()`` passed them in | ||
| the order the senders ran, so results of order-dependent components such as ``DocumentJoiner`` can change for | ||
| ``Pipeline.run()`` too: connect the senders in the order you want the values to arrive. | ||
| ``Pipeline.to_dict()`` now saves connections in the order they were made, so a pipeline loaded with | ||
| ``Pipeline.from_dict()`` keeps the same order. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.