Repository navigation
fix: pass Secret values through in ComponentTool - #13771
Closed
adityav1709 wants to merge 3 commits into
Closed
adityav1709 wants to merge 3 commits into
adityav1709 wants to merge 3 commits into
Conversation
adityav1709
requested review from
davidsbatista
and removed request for
a team
November 16, 2026 11:13
Contributor
|
@adityav1709 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hi @adityav1709, thank you so much for taking the time to work on this! 🙏 Issue #13684 is one our team is handling internally, as noted at the end of its description, so it isn't open for external contributions. To avoid you spending more effort on work that we can't merge, we're closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ComponentTool fails at invocation when a parameter filled through inputs_from_state is typed with Secret (for example access_token: str | Secret). The parameter is correctly hidden from the tool schema, but _convert_param still runs the injected value through TypeAdapter, and Pydantic cannot build a schema for Secret, so it raises PydanticSchemaGenerationError. This happens whether the state value is a plain string or a Secret.
A value typed as Secret (or a union including one) is now passed through unchanged, instead of going through Pydantic. The value reaches the component run as is, which is the expected behavior.
Fixes #13684. Includes a release note and regression tests.
Signed-off-by: adityav1709 adityav170920@gmail.com
Co-authored-by: Muse (Aurora)