Repository navigation
Conversation
|
@DZH166 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
Hi @DZH166, thanks a lot for your contribution! 🙏 We noticed that the Contributor License Agreement (CLA) check ( To get your PR reviewed, please sign the CLA via the link in the Please note that PRs without a signed CLA are automatically closed 48 hours after they were opened. |
|
Hi @DZH166, this PR is still waiting for the Contributor License Agreement (CLA) to be signed. Please note that if the CLA isn't signed within the next 24 hours, this PR will be automatically closed. Signing only takes a minute via the link in the |
|
Hi @DZH166, we're closing this PR because the Contributor License Agreement (CLA) wasn't signed within 48 hours. Thanks a lot for your interest in contributing to Haystack! If you'd still like to see this change merged, please sign the CLA and reopen this PR — it will then automatically be marked ready for review. |
Problem
MultiRetriever.close()andclose_async()run the cleanup of every owned retriever in a bare loop with no per-retriever isolation, so the first retriever whoseclose()raises (already-closed client, dropped connection, close timeout) aborts the loop and every later retriever is never closed - their resources leak while only the unrelated first error surfaces.close_async()has the same flaw on both its native path and its synchronous fallback.Fix
Wrap each close in
try/except BaseException, remember the first failure, finish closing the rest, then re-raise.Tests
test/components/retrievers/test_multi_retriever.py(3 new tests:close,close_async, async sync-fallback):