TOOL-30782 stop depending on crash-python - #567
Merged
Conversation
crash-python is no longer built. It is the Python extension layer that runs inside gdb-python, and gdb-python bundles a readline that predates C23, so GCC 15 rejects its unprototyped termcap calls; the only cheap fix was pinning that tree to -std=gnu17 indefinitely. Both were dropped from linux-pkg in #412, so this reference would otherwise be unsatisfiable. This is the only thing anywhere that pulls crash-python in, and it sits in the DEPENDS block described just above as "tools that are intended for human convenience. The product should not rely on them programmatically", so nothing programmatic is affected. What is lost is on-appliance kernel crash-dump inspection. Dump analysis in practice happens off-appliance with sdb against a saved vmcore, and savedump, makedumpfile and libkdumpfile are all untouched, so collecting a dump still works. The crash-python repo is left in place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
crash-pythonis no longer built — linux-pkg#412 dropped both it andgdb-python, because gdb-python bundles a readline predating C23 and GCC 15 rejects its unprototyped termcap calls; the only cheap fix was pinning that tree to-std=gnu17indefinitely.This
DEPENDSreference is the only thing anywhere that pullscrash-pythonin, so left as-is it is unsatisfiable and fails the appliance build at dependency resolution.Solution
Drop the one line.
We keep crash-dump analysis; we drop the second way of doing it
Worth being explicit, since "remove crash-python" reads worse than it is:
sdbremains available on the appliance, exactly as before. It is in this sameDEPENDSblock and is untouched by this change. It is the tool we actually reach for, it is ours, and it is where the debugging effort goes.drgnremains — the enginesdbis built on.savedump,makedumpfile,libkdumpfileall remain. Dump collection is untouched.So the appliance keeps a complete collect-and-analyse story. What goes away is the crash-python/gdb-python path, the older second way of inspecting the same dumps — duplicating what
sdbalready does, and the only one of the two that will not build on 26.04.sdbis the preferred tool going forward, and this makes it the only one rather than maintaining a parallel toolchain to reach the same place.The line also sits in the
DEPENDSblock described immediately above it as "tools that are intended for human convenience. The product should not rely on them programmatically", so nothing programmatic is affected. Thecrash-pythonrepo itself is left in place.This lands on
os-upgradeto unblock the resolute build. The same change is up for team discussion ondevelop— see #568; if the team wants crash-python kept, this is the branch to revert.Testing Done
Not yet built; validated by the next
build-packages/post-pushrun onos-upgrade. Results on TOOL-30782.