Skip to content

fix(deps): resolve typescript-eslint v8 peer dependency conflict - #794

Closed
OfekAvergil wants to merge 1 commit into
mainfrom
fix/eslint-typescript-peer-conflict
Closed

fix(deps): resolve typescript-eslint v8 peer dependency conflict#794
OfekAvergil wants to merge 1 commit into
mainfrom
fix/eslint-typescript-peer-conflict

Conversation

@OfekAvergil

Copy link
Copy Markdown
Contributor

Related Issues

N/A

Description

#790 bumped @typescript-eslint/eslint-plugin and @typescript-eslint/parser to ^8.0.0, but eslint-config-airbnb-typescript@^17.0.0 (still installed) only supports @typescript-eslint/eslint-plugin up to ^5.13.0 as a peer, and eslint-plugin-jest@^27.0.0 only supports up to ^7.0.0. This breaks npm ci/npm install with an ERESOLVE error, and the local lint-staged pre-commit hook, from a clean checkout of main.

No compatible eslint-config-airbnb-typescript release supports typescript-eslint v8 yet (latest published is 18.0.0, still peer-pinned to ^7.0.0), so this:

  • Reverts @typescript-eslint/eslint-plugin/@typescript-eslint/parser to ^7.0.0
  • Bumps eslint-config-airbnb-typescript to ^18.0.0 to match
  • Regenerates package-lock.json

Verified clean on a fresh checkout: npm ci, npm run lint, npm test (453/453), npm run build.

Must

  • Tests
  • Documentation (if applicable)

#790 bumped @typescript-eslint/eslint-plugin and @typescript-eslint/parser
to ^8.0.0, but eslint-config-airbnb-typescript@^17.0.0 (still installed)
only supports @typescript-eslint/eslint-plugin up to ^5.13.0 as a peer,
and eslint-plugin-jest@^27.0.0 only supports up to ^7.0.0. This broke
npm ci / npm install (ERESOLVE) and the local lint pre-commit hook from
a clean checkout of main.

No compatible eslint-config-airbnb-typescript release supports
typescript-eslint v8 yet (latest published is 18.0.0, still peer-pinned
to ^7.0.0), so this reverts the typescript-eslint bump to ^7.0.0 and
bumps eslint-config-airbnb-typescript to ^18.0.0 to match. Regenerated
package-lock.json.

Verified: npm ci, npm run lint, npm test, npm run build all pass clean.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot

shuni-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

🐕 Suggested Reviewers

This PR resolves a peer dependency conflict introduced by upgrading @​typescript-eslint packages to v8. Since the change only affects package.json and package-lock.json (dependency files), we need reviewers with direct experience maintaining these dependencies. Both candidates have relevant expertise: dorsha has recent changes to package-lock.json (likely dependency-related work), and omercnet has direct package.json maintenance history. Given the narrow scope of this dependency fix, both candidates are valuable—omercnet for understanding the package.json updates and dorsha for validating the lock file resolution.

Reviewer Reason
omercnet omercnet has direct package.json maintenance history and should review the dependency version updates and peer dependency constraints specified in package.json
dorsha dorsha has recent commits to package-lock.json and can validate that the lock file properly resolves the typescript-eslint v8 compatibility with eslint-config-airbnb-typescript and eslint-plugin-jest

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

Comment thread package-lock.json
Comment thread package-lock.json Fixed
Comment thread package-lock.json
Comment thread package-lock.json Fixed
Comment thread package-lock.json
Comment thread package-lock.json
Comment thread package-lock.json Fixed

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni Review

Reverts typescript-eslint to ^7.0.0 and bumps eslint-config-airbnb-typescript to ^18.0.0 to fix an ERESOLVE peer conflict introduced by #790, with a regenerated lockfile.

Actionable comments posted: 0

Merge risk: 🟢 Low: dependency-only change; package-lock.json root manifest and pinned versions (@typescript-eslint/*@7.18.0, eslint-config-airbnb-typescript@18.0.0) are internally consistent and satisfy all peer ranges (including eslint-plugin-jest@27.9.0's ^7.0.0 cap).


Declared coverage: FULL — 2/2 changed files reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant