build: derive the WebRTC cache branch from the pom and guard deploys - #248
Open
SendableMetatype wants to merge 1 commit into
Open
build: derive the WebRTC cache branch from the pom and guard deploys#248SendableMetatype wants to merge 1 commit into
SendableMetatype wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI robustness issues in one commit:
The WebRTC cache branch is pinned as a literal env in the workflows and must be kept in sync with webrtc-jni/pom.xml by hand; when they drift, lanes restore caches for the wrong engine branch. A setup step now derives the value from the pom, making the pom the single source of truth.
The Sonatype deploy steps run unconditionally, so on any fork every fully successful lane concludes as failure from the credentialless 401, and because cache saves are gated on success, fork builds can never warm their caches either. Deploys are now skipped on pull requests and guarded to the devopvoid/webrtc-java repository. Behavior for this repository's own pushes is unchanged.