Add Multi-Measurement support in a single vertex - #27
Open
planthaber wants to merge 15 commits into
Open
Conversation
Collaborator
|
After having a closer look, I have to say that I am against merging this.
|
Collaborator
|
In general, I see three ways to implement this feature:
I have a light tendency towards 3, as it seems the nearest to what was done in this PR. |
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basically adds optional sub-Measurements to VertexObjects and allows to use tags on them, without changing interfaces to slam3d.
This also removes forced graph->optimize() on loading a graph from hdd (so it does not change locations from those loaded from hdd)
Mainly added a std::vector subMeasurements; to a VertexObject allowing sub- measurements with sensor location.
VertexMeasurementData is a new Type containing the sensor data, but VertexObject inherits from it, leaving the interface intact.
Tags are stored in the VertexMeasurementData type, so the VertexOject and submeasurements can be tagged differerently.
A new sensor/pcl/MultiPointCloud sensor is added, which utilizes the new structures and tags.
This newly added structures allow multiple use-cases for slam3d users: