Skip to content

Fix for Xcode 16.3#1076

Merged
LeandraH merged 12 commits into
mainfrom
Fix-for-Xcode-16.3
May 6, 2025
Merged

Fix for Xcode 16.3#1076
LeandraH merged 12 commits into
mainfrom
Fix-for-Xcode-16.3

Conversation

@LeandraH

@LeandraH LeandraH commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Short Description

The latest Xcode version (16.3) doesn't work with older versions of React-Native, this PR bumps us up to a supported one (https://github.com/facebook/react-native/releases/tag/v0.76.9, more info here and here, and some more info on upgrading RN here.

Proposed Changes

  • Upgrade React-Native to version 0.76.9
  • Upgrade Sentry to the latest version
  • Upgrade Xcode version on CircleCI, which should also deal with the complaint from Apple

ITMS-90725: SDK version issue - This app was built with the iOS 17.2 SDK. Starting April 24, 2025, all iOS and iPadOS apps must be built with the iOS 18 SDK or later, included in Xcode 16 or later, in order to be uploaded to App Store Connect or submitted for distribution.

Side Effects

  • Hopefully none

Testing

Pretty much check the entire app 😬

Resolved Issues

This resolves the issue that I can run the iOS app on my machine again, where I stupidly already updated Xcode to the latest version.


@david-venhoff david-venhoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good to me and still works in the emulators :)

Only question I have is why did you remove the yarnrc file and the packageManager field in the package.json files?

Comment thread src/navigation/HomeStackNavigator.tsx Outdated
Comment thread src/navigation/HomeStackNavigator.tsx Outdated
Comment thread src/navigation/UserVocabularyStackNavigator.tsx Outdated
@f1sh1918

f1sh1918 commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

@LeandraH did you check that the ios builds work in the pipeline. as far as i can see this xcode image does not exists
At least when i try it for entitlementcard it tells me that it doesn't exist

https://app.circleci.com/pipelines/github/digitalfabrik/entitlementcard/7960/workflows/77948f68-cd8e-40a0-a2c4-2658afd73c1d/jobs/53884

see further discussion here
https://discuss.circleci.com/t/where-is-xcode-16-3/52979/7

@f1sh1918 f1sh1918 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xcode 16.3.0 is not released for circleCI yet afaics.
Please use xcode 16.2.0 and run a commit_main workflow to ensure that it still builds

@LeandraH

Copy link
Copy Markdown
Contributor Author

Urg, thanks @f1sh1918 ! Sorry about that!

@LeandraH

Copy link
Copy Markdown
Contributor Author

Only question I have is why did you remove the yarnrc file and the packageManager field in the package.json files?

They were changes from the upgrade helper. It looks like that's mainly done to not force anybody to a newer yarn version if they don't want to; since we already use yarn 3, we could keep it in, it probably won't lead to confusion down the line at future updates.

@LeandraH
LeandraH requested a review from f1sh1918 April 22, 2025 10:52
@LeandraH
LeandraH enabled auto-merge April 22, 2025 11:08

@f1sh1918 f1sh1918 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the update. I still can not find a successfully running commit_main where i can see if build_ios still runs without issues @LeandraH

Update you have to add this workflow in @common.yml to run the workflow from CLI or GUI

Comment thread ios/Gemfile.lock Outdated
Comment thread ios/PrivacyInfo.xcprivacy
@LeandraH

Copy link
Copy Markdown
Contributor Author

@f1sh1918 Thank you, can you check again? I updated the bundler and ran a build_ios workflow here.

@f1sh1918 f1sh1918 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thx for the update

@LeandraH
LeandraH merged commit ef92db5 into main May 6, 2025
@LeandraH
LeandraH deleted the Fix-for-Xcode-16.3 branch May 6, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants