Skip to content

PR feedback from app execution changes#34501

Merged
snopoke merged 12 commits into
masterfrom
sk/app-execution-refactor
May 2, 2024
Merged

PR feedback from app execution changes#34501
snopoke merged 12 commits into
masterfrom
sk/app-execution-refactor

Conversation

@snopoke

@snopoke snopoke commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

Technical Summary

Small, non-functional changes from PR feedback: #34487

Note that I'm not addressing this comment for the same of time.

Safety Assurance

Safety story

Changes are non-functional and covered by tests

Automated test coverage

Existing tests

QA Plan

None

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@snopoke snopoke added the product/invisible Change has no end-user visible impact label Apr 25, 2024
@snopoke
snopoke requested a review from esoergel as a code owner April 25, 2024 09:55
@dimagimon dimagimon added the reindex/migration Reindex or migration will be required during or before deploy label Apr 30, 2024
@snopoke

snopoke commented Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

@esoergel bump

@snopoke
snopoke merged commit c6a2e3e into master May 2, 2024
@snopoke
snopoke deleted the sk/app-execution-refactor branch May 2, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product/invisible Change has no end-user visible impact reindex/migration Reindex or migration will be required during or before deploy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants