Propagate app group and role prefixes#406
Open
eguerrant wants to merge 4 commits into
Open
Conversation
rashworld-max
approved these changes
Apr 5, 2026
elaynelemos
reviewed
Apr 6, 2026
| APP_NAME_GROUP_NAME_SEPARATOR = "-" | ||
| APP_GROUP_NAME_PREFIX: ClassVar[str] # set from config at module load, see bottom of file | ||
| APP_NAME_GROUP_NAME_SEPARATOR: ClassVar[str] # set from config at module load, see bottom of file | ||
| APP_OWNERS_GROUP_NAME_SUFFIX = "Owners" |
Contributor
There was a problem hiding this comment.
Hey @eguerrant! I've addded issue #382 (and PR #388) for this customization. Is it possible to also support custom APP_OWNERS_GROUP_NAME_SUFFIX, OKTA_GROUP_NAME_PREFIX, and configurable Okta group sync filter?
rashworld-max
approved these changes
Apr 6, 2026
rashworld-max
approved these changes
Apr 6, 2026
barborico
previously approved these changes
Apr 9, 2026
Contributor
Why is this? Do the overrides not merge with the defaults provided in |
eguerrant
force-pushed
the
propagate_group_prefixes
branch
from
b35c02c to
e4ea38c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, reserved app group and role prefixes (by default 'App-' and 'Role-' were set in the back end but not propagated to the front end, which could lead front end group name validation to be incorrect if those values were changed from the default ones. Added these values to config so that they are set in one place and used everywhere
I think this will require people to update their override files whether or not they are using non-default name prefixes, might be worth setting up a new release after this merges (since group requests have also been added recently) and noting this as a breaking change