feat: search app groups by name on the app page#524
Merged
Conversation
The app page search box previously filtered app groups only by member (a group appeared if it had an active member matching by name or email). Extend the `q` filter so it also matches a group's own name, letting users find a specific app group or a subset (e.g. all groups containing "Prd") by a case-insensitive substring without scrolling the full list. The single search box now matches group name OR member; relabel it from "Search Users" to "Search groups or users". No API schema change.
Regenerate the app-groups endpoint description in the OpenAPI client to match the updated backend docstring, keeping the openapi-client-drift check green.
somethingnew2-0
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the App page search box so it also matches an app group's own name, not just its members.
Urgency: 5 days
Expected review effort: LOW
Motivation
On an app with many groups, confirming whether a specific app group exists, or finding a subset of groups (e.g. all groups containing
Prd), currently requires scrolling the full list. The search box only filtered by member, so searching for a group name returned nothing.Description of Changes
GET /api/apps/{id}/groups): theqfilter now matches a group whose own name contains the query (case-insensitive substring) OR that has an active member matching by name/email. The existing member-match behavior is unchanged.qplumbing carries the query.qwas already an optional query param.Validation of Changes
qmatching a group name returns that group, and that a subset query (e.g.prd) matches by case-insensitive substring. Written test-first: confirmed it failed before the change and passes after.ruff,ty, and the fulltests/test_app.pysuite pass; frontendtsc --noEmitis clean.Sim,00005,Alpha.Guidance for Reviewers
Single commit, small changeset. The key logic change is the one-line
or_(AppGroup.name.ilike(like), member_match)inapi/routers/apps.py; the rest is the label change and stale-comment updates.