Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces asynchronous event ingestion for Trace events and implements an option pattern for customizing traces. Key changes include the addition of new option functions in pkg/langfuse/options.go, comprehensive tests for client behavior in pkg/langfuse/client_test.go, and a refactor that removes the legacy pkg/client files.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/langfuse/options.go | Adds WithTags and WithSessionID options to customize trace objects. |
| pkg/langfuse/client.go & client_test.go | Implements async event sending and prompt template conversion with accompanying tests. |
| internal/observer/.go and internal/models/.go | Introduces and integrates the observer pattern and updated models for ingestion events. |
| pkg/client/* | Removes legacy client files in favor of the new implementation in pkg/langfuse. |
| go.mod | Updates module dependencies to support the new functionality. |
Comments suppressed due to low confidence (1)
pkg/client/client.go:1
- [nitpick] The removal of the legacy 'client' package files appears intentional. Please ensure that all references to these files are updated accordingly.
package client
emranbm
enabled auto-merge
May 14, 2025 14:49
mehran-prs
reviewed
May 17, 2025
mehran-prs
reviewed
May 17, 2025
mehran-prs
reviewed
May 17, 2025
emranbm
force-pushed
the
ingestion
branch
2 times, most recently
from
July 19, 2025 14:29
4607987 to
6f0bc96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send ingestion events (currently just
Traces) in async batches. Best regards to the old implementation sample