[DAP-17] TaskConf AAD Part 1: Add canonical TaskConfiguration builder and conversions#4672
Merged
Conversation
… and forward conversions Foundation for binding TaskConfiguration into HPKE AADs: - `VdafInstance::to_vdaf_config` and `BatchMode::to_batch_config` forward conversions (inherent methods, since orphan rules block `From` impls). - `janus_core::task_config::build_task_configuration`, the single (prod, at least) path that normalizes endpoint URLs and the `task_interval` extension, with an encoded test vector. We'll be using this elsewhere.
tgeoghegan
approved these changes
Jun 29, 2026
divergentdave
approved these changes
Jun 29, 2026
Comment on lines
+192
to
+194
| VdafInstance::FakeFailsVerifyInit | VdafInstance::FakeFailsVerifyStep => { | ||
| return Err("VDAF instance has no VdafConfig representation"); | ||
| } |
Collaborator
There was a problem hiding this comment.
Thinking ahead, we might need to just return VdafConfig::Fake with a fixed number of rounds, or do something else, in order for the relevant tests to go through once we start calling this in the aggregator.
Contributor
Author
There was a problem hiding this comment.
Yeah, honestly not sure yet :)
Co-authored-by: David Cook <divergentdave@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foundation for binding TaskConfiguration into HPKE AADs:
VdafInstance::to_vdaf_configandBatchMode::to_batch_configforward conversions (inherent methods, since orphan rules blockFromimpls).janus_core::task_config::build_task_configuration, the single (prod, at least) path that touches endpoint URLs and thetask_intervalextension, with an encoded test vector. We'll be using this elsewhere.Part plan:
This is part of #4402