[codex] fix OmniLogic compressed response boundaries#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Applies the protocol-level boundary fix in the integration compatibility layer:
MsgSize;Why
The prior streaming fallback kept the integration working, but the source problem is the
rstrip(b"\x00")heuristic. A valid zlib trailer can end with0x00; removing it makes a complete response look truncated. The controller already declares the exact response length in its lead message.The new code uses that length and keeps one-shot zlib decompression strict. It continues to accept protocol padding after a completed zlib stream and rejects truly incomplete compressed data.
Validation
MsgSize=3937, reassembled payload3937bytes)The separate upstream library fix is tracked in cryptk/python-omnilogic-local#153. This compatibility code can be removed once a released library contains that fix.