std.regex: document that ctRegex always uses the backtracking engine#11026
Merged
Conversation
ctRegex pins CtfeFactory!(BacktrackingMatcher, ...) via withFactory, bypassing the runtime engine auto-selection that picks the Thompson matcher for patterns without backreferences. There is no compile-time code generator for the Thompson engine, so ctRegex matching carries no linear-time guarantee. Document this trade-off so users handling untrusted input can make an informed choice.
Contributor
|
Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#11026" |
DmitryOlshansky
approved these changes
Jun 7, 2026
DmitryOlshansky
left a comment
Member
There was a problem hiding this comment.
Yes, it's fair to warn about the nature of the engine being used.
thewilsonator
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctRegex pins CtfeFactory!(BacktrackingMatcher, ...) via withFactory, bypassing the runtime engine auto-selection that picks the Thompson matcher for patterns without backreferences. There is no compile-time code generator for the Thompson engine, so ctRegex matching carries no linear-time guarantee. Document this trade-off so users handling untrusted input can make an informed choice.